Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932827AbWLSQvk (ORCPT ); Tue, 19 Dec 2006 11:51:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932832AbWLSQvk (ORCPT ); Tue, 19 Dec 2006 11:51:40 -0500 Received: from smtp.osdl.org ([65.172.181.25]:45133 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932827AbWLSQvj (ORCPT ); Tue, 19 Dec 2006 11:51:39 -0500 Date: Tue, 19 Dec 2006 08:51:16 -0800 (PST) From: Linus Torvalds To: Nick Piggin cc: Peter Zijlstra , Andrew Morton , andrei.popa@i-neo.ro, Linux Kernel Mailing List , Hugh Dickins , Florian Weimer , Marc Haber , Martin Michlmayr Subject: Re: 2.6.19 file content corruption on ext3 In-Reply-To: <4587B762.2030603@yahoo.com.au> Message-ID: References: <1166314399.7018.6.camel@localhost> <20061217040620.91dac272.akpm@osdl.org> <1166362772.8593.2.camel@localhost> <20061217154026.219b294f.akpm@osdl.org> <1166460945.10372.84.camel@twins> <45876C65.7010301@yahoo.com.au> <45878BE8.8010700@yahoo.com.au> <4587B762.2030603@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 30 On Tue, 19 Dec 2006, Nick Piggin wrote: > > Counterexample? Well AFAIKS, the clearing of PG_dirty in ttfb() in > response to finding all buffers clean is perfectly valid. What makes > you think otherwise? If the page really is clean, then why the heck cant' we just clean the page table bits too? Either it's clean or it isn't. If all the buffers being clean means that the page is clean, then it's clean. WE SHOULD NOT THINK THAT PTE'S ARE ANY DIFFERENT. I really don't see your point. Is it clean? If it is, then clear the damn dirty bits from the page tables too. Don't go pussyfooting around the issue and confuse yourself and everybody but me by saying "but if it's dirty in the page tables, it's magically dirty". NO. It really is that simple. Is it clean or not? If it's clean, you can remove ALL the dirty bits. Not just some. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/