Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c00d96ef-0168-c004-7fb1-a422a7c8aaa3@gmail.com>
Date:   Sat, 2 Oct 2021 21:39:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Cc:     saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter
Content-Language: en-US
To:     Michael Straube <straube.linux@gmail.com>,
        Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <YVh3MP/JrUwkKr3Y@user>
 <59ac1835-2afd-cd7a-d073-5c5d2bb02805@gmail.com>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
In-Reply-To: <59ac1835-2afd-cd7a-d073-5c5d2bb02805@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 02/10/21 9:08 pm, Michael Straube wrote:
> Thanks for you patch Saurav, just some minor style issue.
> 
> On 10/2/21 17:13, Saurav Girepunje wrote:
>> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>>   drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c 
>> b/drivers/staging/r8188eu/core/rtw_efuse.c
>> index 801887f497cf..d33a5b3b4088 100644
>> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
>> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
>> @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>>   #define REG_EFUSE_CTRL        0x0030
>>   #define EFUSE_CTRL            REG_EFUSE_CTRL        /*  E-Fuse 
>> Control. */
>>
>> -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
>> -                       u16 Offset,
>> +static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
>>                          u8 *Value)
> 
> There is no need for a line break here.                 ^
> 
> Other than that looks good to me.
> 
> Thanks,
> Michael

Thanks Michael for review. Yes line break not needed here. I will 
update. I will resend the patch.

Regards,
Saurav