Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mount.2: note that mandatory locking is now fully
 deprecated
To:     Jeff Layton <jlayton@kernel.org>
Cc:     mtk.manpages@gmail.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
        linux-man@vger.kernel.org
References: <20211001115724.16392-1-jlayton@kernel.org>
From:   "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Message-ID: <70df73be-1f6a-2317-fe60-79c9d0575d5e@gmail.com>
Date:   Sat, 2 Oct 2021 19:39:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211001115724.16392-1-jlayton@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Jeff,

On 10/1/21 1:57 PM, Jeff Layton wrote:
> This support has been fully removed from the kernel as of v5.15.
> 
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>   man2/mount.2 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/mount.2 b/man2/mount.2
> index bedd39e68a68..a7ae65fb0142 100644
> --- a/man2/mount.2
> +++ b/man2/mount.2
> @@ -195,7 +195,8 @@ this mount option requires the
>   .B CAP_SYS_ADMIN
>   capability and a kernel configured with the
>   .B CONFIG_MANDATORY_FILE_LOCKING
> -option.
> +option. Mandatory locking has been fully deprecated in v5.15 kernels, so
> +this flag should be considered deprecated.

Please use semantic newlines, as man-pages(7) notes.  It is especially 
important here, as otherwise you're hardcoding the number of spaces 
after the '.' (which if you don't, will typically be 2).

See man-pages(7):

    Use semantic newlines
        In the source of a manual page,  new  sentences  should  be
        started  on  new  lines, and long sentences should be split
        into lines at clause breaks  (commas,  semicolons,  colons,
        and  so on).  This convention, sometimes known as "semantic
        newlines", makes it easier to see the  effect  of  patches,
        which often operate at the level of individual sentences or
        sentence clauses.


Cheers,

Alex

>   .TP
>   .B MS_NOATIME
>   Do not update access times for (all types of) files on this filesystem.
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/