Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/msm: dsi: Remove redundant null check before
 clk_prepare_enable/clk_disable_unprepare
To:     Xu Wang <vulab@iscas.ac.cn>, robdclark@gmail.com, sean@poorly.run,
        airlied@linux.ie, daniel@ffwll.ch, tzimmermann@suse.de,
        mka@chromium.org, harigovi@codeaurora.org,
        emil.velikov@collabora.com, rikard.falkeborn@gmail.com,
        viresh.kumar@linaro.org, rnayak@codeaurora.org
Cc:     linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
        freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20201231095616.25973-1-vulab@iscas.ac.cn>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Message-ID: <3de6b365-7ef7-e191-a072-c7bd418c519b@linaro.org>
Date:   Sat, 2 Oct 2021 22:48:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20201231095616.25973-1-vulab@iscas.ac.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 31/12/2020 12:56, Xu Wang wrote:
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 15 ++++++---------
>   1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index ab281cba0f08..e7af90f045bf 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -565,13 +565,11 @@ int dsi_link_clk_enable_6g(struct msm_dsi_host *msm_host)
>   		goto pixel_clk_err;
>   	}
>   
> -	if (msm_host->byte_intf_clk) {
> -		ret = clk_prepare_enable(msm_host->byte_intf_clk);
> -		if (ret) {
> -			pr_err("%s: Failed to enable byte intf clk\n",
> -			       __func__);
> -			goto byte_intf_clk_err;
> -		}
> +	ret = clk_prepare_enable(msm_host->byte_intf_clk);
> +	if (ret) {
> +		pr_err("%s: Failed to enable byte intf clk\n",
> +			   __func__);
> +		goto byte_intf_clk_err;
>   	}
>   
>   	return 0;
> @@ -667,8 +665,7 @@ void dsi_link_clk_disable_6g(struct msm_dsi_host *msm_host)
>   	dev_pm_opp_set_rate(&msm_host->pdev->dev, 0);
>   	clk_disable_unprepare(msm_host->esc_clk);
>   	clk_disable_unprepare(msm_host->pixel_clk);
> -	if (msm_host->byte_intf_clk)
> -		clk_disable_unprepare(msm_host->byte_intf_clk);
> +	clk_disable_unprepare(msm_host->byte_intf_clk);
>   	clk_disable_unprepare(msm_host->byte_clk);
>   }
>   
> 


-- 
With best wishes
Dmitry