Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2621564pxb; Sun, 3 Oct 2021 00:35:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz42TnlCCLXpY+g0DB2yOx/YRKIc9bXzfGxawQXnw8Y8VifqH2RHzMQl9w1ulnPC9oD4E/T X-Received: by 2002:a50:9d0e:: with SMTP id v14mr9719866ede.230.1633246553315; Sun, 03 Oct 2021 00:35:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633246553; cv=none; d=google.com; s=arc-20160816; b=QPVDXJxNrhz5HQ/1c//EWf8GfS50aMD2UXN8NkR8HXnpediUp09uyN4CmDVDPjxaH0 2EJn7PArRZ5DagBQ9XyZxHW7MekeP7rxrnuTdv1+7xojvQrBIEbe48PwYs7cczSRf/m9 9BixjuY6R7tTsRfmhX/e8XUCNYJzhHT8Yr51IhWfjNF/JKXjbO6Mh6sXcTpVyhwI98qk a6U9Al6cR1mKlqdPIV7oCHGm1fldhAjkDvTKnfxuiJhrd8+ayOsLtyo3Y6pvmf+xo7HB /Ydu+6l7b+2vnl+ab9A4fOtFAlE1xhgv4qKCEVv0xgR9/8hUyCix1WO6Ph82X4cfK1Ms qj2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:abuse-reports-to:tuid:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=sPnHztzJAriZ57HaDsZAs5tTz3QCvtJ4XoOaiLZXKOU=; b=04/4pQh3aBrruVJ+LfGa61Q2YqgMFhFxvVQ/W6f6j3mHN2L5QxEwhSsCvsur92akvi YqM/VfjHy4ghSs6hsB7hnm72HdL25XWirEklu13a4u4uOKsyoCVGuL+z5ixSdSTA2553 C+ZW2wM4TDJiml7EdWUxJJQwVvlUnAq192R5PyEIraWfEdUP7Y/d/JHy0cgqSs5YiPDl JsupMAigQVhcfMMz998hNSQYvJ/rVtnB6lCYFCAznsqHqdXnoQD+9UvRXs1pkgqKk05g rQ4AfhiBU+471eQsmhV2joCHyOnh+qecI2E9uSJboknUjRRRMWpHg6sBlhte5wgZCG09 Ty3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si12823805eje.228.2021.10.03.00.35.29; Sun, 03 Oct 2021 00:35:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbhJCHaj (ORCPT + 99 others); Sun, 3 Oct 2021 03:30:39 -0400 Received: from unicom145.biz-email.net ([210.51.26.145]:45148 "EHLO unicom145.biz-email.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbhJCHai (ORCPT ); Sun, 3 Oct 2021 03:30:38 -0400 Received: from ([60.208.111.195]) by unicom145.biz-email.net ((LNX1044)) with ASMTP (SSL) id WHF00045; Sun, 03 Oct 2021 15:28:45 +0800 Received: from localhost.localdomain (10.200.104.119) by jtjnmail201605.home.langchao.com (10.100.2.5) with Microsoft SMTP Server id 15.1.2308.14; Sun, 3 Oct 2021 15:28:43 +0800 From: Kai Song To: CC: , , , , , , , Kai Song Subject: [PATCH] staging: r8188eu: Use kmemdup() to replace kmalloc + memcpy Date: Sun, 3 Oct 2021 15:28:41 +0800 Message-ID: <20211003072841.215903-1-songkai01@inspur.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.200.104.119] tUid: 2021100315284586480ab6b99732ccbe6ed0624a85d86d X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix memdup.cocci warning: drivers/staging/r8188eu/os_dep/ioctl_linux.c:4452:33-40: WARNING opportunity for kmemdup Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by: Kai Song --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c index 20f6182fd93c..71843690356a 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -4189,12 +4189,11 @@ static int rtw_wx_set_priv(struct net_device *dev, kfree(pmlmepriv->wps_probe_req_ie); pmlmepriv->wps_probe_req_ie = NULL; - pmlmepriv->wps_probe_req_ie = kmalloc(cp_sz, GFP_KERNEL); + pmlmepriv->wps_probe_req_ie = kmemdup(probereq_wpsie, cp_sz, GFP_KERNEL); if (!pmlmepriv->wps_probe_req_ie) { ret = -EINVAL; goto FREE_EXT; } - memcpy(pmlmepriv->wps_probe_req_ie, probereq_wpsie, cp_sz); pmlmepriv->wps_probe_req_ie_len = cp_sz; } goto FREE_EXT; -- 2.27.0