Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2915497pxb; Sun, 3 Oct 2021 09:12:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEH83VRFvpe7wjQvvBqSb3I2B3vInx+ejqxzVOwYcky359vC4vNdKyDfuSZLVblAoqG6Lm X-Received: by 2002:a17:902:e8c9:b0:13d:dae7:1d5b with SMTP id v9-20020a170902e8c900b0013ddae71d5bmr19015933plg.39.1633277576059; Sun, 03 Oct 2021 09:12:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633277576; cv=none; d=google.com; s=arc-20160816; b=v2eT8x0ZuKHbyXjmUeadFym3+C/DfQMRbtRMFbT7zdMFP0E9GTb7WhGo8pPKOHtQf2 z1aehdBYyJfx/cHHEpAh34Oxv2++h0FmlTrmWOmK8MpmZQi2frQq9Xpfd9sRaektmjDF /IQWqStpkqoJyrjzbS3xu3KgHSRdMNpjO3v9GOoE8zCBSOx2asXIuUJ+UIc5h2YuLbTa Xp6VKHBhSXaKnqVkn++VOeyOVKaKAfbsU6zQC3kmPYHe+KgoFGBZSfDN5V3NGA9hy3W2 FA7XRrco5T73m/LprYbm8PtLhc9vpzmj5ZN4utYx9rjjdEBvi8Wh3Kvc/DP0gUMpkVu4 TEpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Bv8CMwUVGXwTfA+jSvAvwCfiz9u/tkWuNusm3outo6E=; b=U27xMYHYw75rHdSLKvEgIVLvqHwglANDKhr+R5Zd/NefFJ1LFd2bad39xfC5LN92Nr pMiFZ3szsA8j3sWykDFOnFwVYweqREHJQx0hTEFsWAotX73qLxqu8WU/1RfDqEnPLhbX W6kMO8nqK0hKAtKbie4IuGr5CekkopjOFJDgsPfv86aAh5Y2PZv+KAK1UC079lK5JV5f m1TGLWsyXOV541/1hnFsPi01E7u2vxf2Og0BA49/elHm2KxYUUiS3erW+dlnUvkMXmpw 016NhR2HQ5zLw+mFnQk2L/dZWprW8kepxSmGUGE0LgOzRxNRaiW/AFd+d1ju7J6kd6aE tyMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si5866123pgh.124.2021.10.03.09.12.10; Sun, 03 Oct 2021 09:12:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbhJCQLY (ORCPT + 99 others); Sun, 3 Oct 2021 12:11:24 -0400 Received: from elvis.franken.de ([193.175.24.41]:57376 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230489AbhJCQLW (ORCPT ); Sun, 3 Oct 2021 12:11:22 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mX43M-0005aq-00; Sun, 03 Oct 2021 18:09:28 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3F223C1D2A; Sun, 3 Oct 2021 18:07:05 +0200 (CEST) Date: Sun, 3 Oct 2021 18:07:05 +0200 From: Thomas Bogendoerfer To: Sergio Paracuellos Cc: robh@kernel.org, arnd@arndb.de, catalin.marinas@arm.com, Liviu.Dudau@arm.com, bhelgaas@google.com, matthias.bgg@gmail.com, gregkh@linuxfoundation.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, linux-staging@lists.linux.dev, neil@brown.name, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] Revert "MIPS: ralink: don't define PC_IOBASE but increase IO_SPACE_LIMIT" Message-ID: <20211003160705.GA4984@alpha.franken.de> References: <20210925203224.10419-1-sergio.paracuellos@gmail.com> <20210925203224.10419-2-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210925203224.10419-2-sergio.paracuellos@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 25, 2021 at 10:32:19PM +0200, Sergio Paracuellos wrote: > This reverts commit 159697474db41732ef3b6c2e8d9395f09d1f659e. > > There is no real need to increase IO_SPACE_LIMIT if PCI_IOBASE > is properly set to 'mips_io_port_base'. Hence revert this commit > first before doing anything else. > > Signed-off-by: Sergio Paracuellos > --- > arch/mips/include/asm/mach-ralink/spaces.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/mach-ralink/spaces.h b/arch/mips/include/asm/mach-ralink/spaces.h > index 31a3525213cf..87d085c9ad61 100644 > --- a/arch/mips/include/asm/mach-ralink/spaces.h > +++ b/arch/mips/include/asm/mach-ralink/spaces.h > @@ -2,7 +2,9 @@ > #ifndef __ASM_MACH_RALINK_SPACES_H_ > #define __ASM_MACH_RALINK_SPACES_H_ > > -#define IO_SPACE_LIMIT 0x1fffffff > +#define PCI_IOBASE _AC(0xa0000000, UL) > +#define PCI_IOSIZE SZ_16M > +#define IO_SPACE_LIMIT (PCI_IOSIZE - 1) > > #include > #endif Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]