Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1bad16dc-e11e-4096-2014-a0eae92686e8@gmail.com>
Date:   Sun, 3 Oct 2021 19:19:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH] media: atomisp: fix `-Werror=return-type`
Content-Language: en-US
To:     Ammar Faizi <ammar.faizi@students.amikom.ac.id>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Bedirhan KURT <windowz414@gnuweeb.org>
References: <20211002231723.29019-1-ammar.faizi@students.amikom.ac.id>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20211002231723.29019-1-ammar.faizi@students.amikom.ac.id>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/3/21 02:17, Ammar Faizi wrote:
> Bedirhan reported build error:
> ```
>    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
>    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
>     1649 | }
>          | ^
>    cc1: some warnings being treated as errors
>    make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1
>    make[3]: *** [scripts/Makefile.build:540: drivers/staging/media/atomisp] Error 2
>    make[2]: *** [scripts/Makefile.build:540: drivers/staging/media] Error 2
>    make[1]: *** [scripts/Makefile.build:540: drivers/staging] Error 2
>    make: *** [Makefile:1868: drivers] Error 2
> ```
> 
> Commit 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp:
> remove useless returns") incorrectly removed a required return results
> in the above build error. Reinstate it.
> 
> Cc: Pavel Skripkin <paskripkin@gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-staging@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
> Reported-by: Bedirhan KURT <windowz414@gnuweeb.org>
> Fixes: 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp: remove useless returns")
> Signed-off-by: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
> ---
>   .../media/atomisp/pci/hive_isp_css_common/host/input_system.c    | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..1bd917e81743 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
>   	default:
>   		return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
>   	}
> +	return INPUT_SYSTEM_ERR_NO_ERROR;
>   }
>   
>   // Test flags and set structure.
> 

Hi, Ammar!


Thank you for fixing this, but it's already fixed in linux-next tree. 
See commit 05344a1d2ea7 ("media: atomisp: restore missing 'return' 
statement").

Again, I am sorry for introducing this bug :(


With regards,
Pavel Skripkin