Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show()
To:     Matthew Wilcox <willy@infradead.org>,
        Nghia Le <nghialm78@gmail.com>
Cc:     akpm@linux-foundation.org, nathan@kernel.org,
        ndesaulniers@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        lukas.bulwahn@gmail.com, kernel-janitors@vger.kernel.org
References: <20211003114113.109463-1-nghialm78@gmail.com>
 <YVm2MHbhEU0b7HPM@casper.infradead.org>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <ccee8f63-f5dd-6231-5625-a67ad3b80a6d@oracle.com>
Date:   Sun, 3 Oct 2021 19:36:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <YVm2MHbhEU0b7HPM@casper.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0Y2L1JXano0SGc5TzJVNEdlR2JUZlRUanBUUFpKRHVtUEJKWWZyV0k0R1pB?=
 =?utf-8?B?ZmViN1J3cjhwTmhMbnFuN3VXajJoaldmcmZiMmRrTFpKNmdOZVk4Y3JTbmN3?=
 =?utf-8?B?ZVVOTmxFUTZYZWlUYUtpWjM3aDl6akJqNnBvL05CaXlZY1U1OStqK0x2MW5X?=
 =?utf-8?B?TnR2SUNqQUVOMjRPOFhDR24xMU5ncVJQOXV5eHU5V1B4NUN2bXpxbjU3YlBV?=
 =?utf-8?B?YjdEUHFqSVJJQmJTd0FVTlpxdlFtcDVEM3kxeWk3aTlCU1UvVmRzUWtjSXdM?=
 =?utf-8?B?ZHRHeUdadVoxSG85R1Vud1hoaUE1cVZ1VExEbjBlU0lVaGo5YmJEMExhZXQz?=
 =?utf-8?B?OW5qNERpYTkxRDlBV1IzUUdpQisxWTRJdE5JcThNZDNEL3c4RnlkYlBhZkNL?=
 =?utf-8?B?LzBNOE1EOUlubWxmQzF3ZS9aZUFjS3hJNjFXMWpxVzBiaVNKM1hOemxsZDcw?=
 =?utf-8?B?TzJrRVNCbVZxMzJVME42ODByZVY0ZHNvcXZYaXRUZ3VSQjdjRGN6dHVJV3N3?=
 =?utf-8?B?Q0djYVJJYkVqZHJFNm1YMi9EYnhOTHN0S0o3aGJkaE1vRWpjYXVwUWkxd0Ni?=
 =?utf-8?B?ZTU3RUVvRnRsMHpOV2VoY2ora29lYlNwMzgxc2UwVmZzeHZYMC9hVVQxK2Fx?=
 =?utf-8?B?VElkYXMzVklUekdVejNEZ3pVWTc1S2VtNjIvUzN4SEMrZUlaVFVaWlI1ZGkv?=
 =?utf-8?B?bkxCTlBMd0Vtczl2TStyYnI2bDV3WVZzY2EramlLaThqbjZvZnZ1YUZWVVNj?=
 =?utf-8?B?TUVoeUtWZGR4ODV2dmZkc1FIdlhsY0N6VGIzZ3JlTHQxU3hFcUJWRmV0anV1?=
 =?utf-8?B?Tk95YXQvaXM1bW9jTGYxWGpkTmhRbEpSM2t2OEQzY0RNb0RwWTBhcXRyM1JE?=
 =?utf-8?B?N09iRzY0TG5NNk1JeXRNbmE2cjZCcDVqMldQZ3dKa0I2d2hBNk5rWksrRERs?=
 =?utf-8?B?dUNORmFDYW9RQ0FkcW5HNEZBaFFsVFZMaWROV2N6UUMvNnVqb3MvVVE4empW?=
 =?utf-8?B?OHI4dzNuZEZnOFp2S3QrUCtkR3czU1NKU1NqZXJZN2NJQysrVDVLYnlXZnFq?=
 =?utf-8?B?MGMrUlBTWC9KRmk3ZWJkdWQ0MHFkSzhwYmpEY1FiNFkzZXM1TVVoYjdCek1T?=
 =?utf-8?B?SlYzREs5VVNJVWlSK3g4WnVIaXpBMmNEcTVwcVVwUzNjRHk4c3BJb0N1SHVL?=
 =?utf-8?B?WFBRSEZ1SFgzQ0t6Z05tL1diQXJZM3J0RG5CdTRkOUJ6WXMrU3BvV0RYYlU2?=
 =?utf-8?B?YmpIV25DejYrb2dPMWFUQXVUY3pnT25hTm9mY3NjNkdGUVkzM1Y5Y0RaNHA1?=
 =?utf-8?B?VWhqM1Y1TlpQWEZuK1dTbmtWeFNDOUFqYTd5YVU3QjFBWGI1bVVrbXFkUHNv?=
 =?utf-8?B?SngwajFqMDZOTW5JTGp6WFBFK0hnd3lVR1Q1KzRwU3dLTVFVL1dUTTRWelNR?=
 =?utf-8?B?RjlsL04veXAvalBUWUhUV0UzRnk2UHZocTN5RHJwRmJhOEJmQ1ZpaGJseG5D?=
 =?utf-8?B?bHBsdGwxemRHSlBUR0l1bWNlVXFtWmdPOUVVRHlWVk1ZbCtsVldjaUI2T1Fy?=
 =?utf-8?B?ZXJpRGNSSk5sK0ZpcFpteDhQN1N5bnJKRnduWHpEQ0kwT0szT3owM1FJNFBO?=
 =?utf-8?B?TjRzY09OU0I5MHdwTFJPYVlOK1YxVHVHVytEUzgzdDBVRzJUUjhRd2pmNGJj?=
 =?utf-8?B?NlM1VzZvcGZJaFRML1JybjFacjA4QkhhbU1iL2pmMmoxUENwQ0d4emxYc2pt?=
 =?utf-8?Q?dpMg3aHTSCuhStEKwv0bCi9RTaCi3zWo6B+fX4X?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22862634-afbb-4a50-94bc-08d986dfd5e8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 02:36:57.7111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F3iWWg329OUXSIg5wB94xBqDKtIaB2YAZElVlIK6GtPb5P5AdP+j1ahoHB9nkCBwQqQ5oYamsFiBVGWGCRepUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4354
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10126 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110040018
X-Proofpoint-ORIG-GUID: kn-V5KyN_peEPtboJcEQWVoSKLtbrRIG
X-Proofpoint-GUID: kn-V5KyN_peEPtboJcEQWVoSKLtbrRIG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/3/21 6:54 AM, Matthew Wilcox wrote:
> On Sun, Oct 03, 2021 at 06:41:13PM +0700, Nghia Le wrote:
>>  {
>>  	struct hstate *h;
>> -	unsigned long demote_size;
>>  	int nid;
>>  
>>  	h = kobj_to_hstate(kobj, &nid);
>> -	demote_size = h->demote_order;
>>  
>>  	return sysfs_emit(buf, "%lukB\n",
>>  			(unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
> 
> I'd suggest this function would look better written as:
> 
> 	int nid;
> 	struct hstate *h = kobj_to_hstate(kobj, &nid);
> 	unsigned long demote_size = (PAGE_SIZE << h->demote_order) / SZ_1K;
> 
> 	return sysfs_emit(buf, "%lukB\n", demote_size);
> 

Thank you Nghia Le for spotting this, and thank you Matthew for the
suggestion.

This is still just in Andrew's tree and subject to modification before
the next merge window.  I am still expecting additional comments on the
series.

If another version of the series is needed, I will include Matthew's
suggestion.   If not, I will ask Andrew how he would prefer to fold in
the changes.
-- 
Mike Kravetz