Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 Oct 2021 10:44:41 +0700
From:   Nghia Le <nghialm78@gmail.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     Matthew Wilcox <willy@infradead.org>, akpm@linux-foundation.org,
        nathan@kernel.org, ndesaulniers@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        lukas.bulwahn@gmail.com, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show()
Message-ID: <20211004034441.GA114074@ubuntu>
References: <20211003114113.109463-1-nghialm78@gmail.com>
 <YVm2MHbhEU0b7HPM@casper.infradead.org>
 <ccee8f63-f5dd-6231-5625-a67ad3b80a6d@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ccee8f63-f5dd-6231-5625-a67ad3b80a6d@oracle.com>
Precedence: bulk

On Sun, Oct 03, 2021 at 07:36:54PM -0700, Mike Kravetz wrote:
> On 10/3/21 6:54 AM, Matthew Wilcox wrote:
> > On Sun, Oct 03, 2021 at 06:41:13PM +0700, Nghia Le wrote:
> >>  {
> >>  	struct hstate *h;
> >> -	unsigned long demote_size;
> >>  	int nid;
> >>  
> >>  	h = kobj_to_hstate(kobj, &nid);
> >> -	demote_size = h->demote_order;
> >>  
> >>  	return sysfs_emit(buf, "%lukB\n",
> >>  			(unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
> > 
> > I'd suggest this function would look better written as:
> > 
> > 	int nid;
> > 	struct hstate *h = kobj_to_hstate(kobj, &nid);
> > 	unsigned long demote_size = (PAGE_SIZE << h->demote_order) / SZ_1K;
> > 
> > 	return sysfs_emit(buf, "%lukB\n", demote_size);
> >
Thanks Matthew for the clean code.
> 
> Thank you Nghia Le for spotting this, and thank you Matthew for the
> suggestion.
> 
> This is still just in Andrew's tree and subject to modification before
> the next merge window.  I am still expecting additional comments on the
> series.
> 
> If another version of the series is needed, I will include Matthew's
> suggestion.   If not, I will ask Andrew how he would prefer to fold in
> the changes.
> -- 
> Mike Kravetz
Thanks Mike, so we will wait further comments from Andrew and others.