Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 Oct 2021 06:01:09 +0000
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
To:     David Rientjes <rientjes@google.com>
Cc:     Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [QUESTION] is SLAB considered legacy and deprecated?
Message-ID: <20211004060109.GA2949@linux.asia-northeast3-a.c.our-ratio-313919.internal>
References: <20210927090347.GA2533@linux.asia-northeast3-a.c.our-ratio-313919.internal>
 <8aa15f4b-71de-5283-5ebc-d8d1a323473d@suse.cz>
 <20210928111231.GA2596@linux.asia-northeast3-a.c.our-ratio-313919.internal>
 <b3c5bd9a-5fbc-8388-a4ab-6c20864dc7c6@suse.cz>
 <20211003055928.GA7643@linux.asia-northeast3-a.c.our-ratio-313919.internal>
 <377a622-9a5e-37dc-8f8d-42ae124042b6@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <377a622-9a5e-37dc-8f8d-42ae124042b6@google.com>
Precedence: bulk

On Sun, Oct 03, 2021 at 06:25:29PM -0700, David Rientjes wrote:
> On Sun, 3 Oct 2021, Hyeonggon Yoo wrote:
> 
> > I think the points are still valid because on some workloads SLAB works
> > better. especially when alloc/frees are intensive, SLUB tends to become
> > bottleneck.
> > 
> > If we can't drop SLAB, it should be at least maintained :(
> > But it has been neglected for a long time, which makes people not to
> > use SLAB. Nobody likes to use a subsystem that isn't maintained.
> > 
> > Anyway, I'm curious about share of SLAB and SLUB and on what situations
> > SLAB or SLUB is preferred. that information would help maintain both.
> > 
> 
> Thanks for raising this, the discussion is always useful.  Both allocators 
> have their pros and cons.
>

Thanks for kind words, I was curious and wanted to help improve
SLAB

> I would disagree that SLAB isn't currently maintained, I think it's 
> actively maintained.

I thought it was not actively maintained because most of patches were
fixups and cleanups for years and as Vlastimil said, new features are
only added to SLUB. development was focused on SLUB.

> I think the general guidance is that changes for both allocators can still
> be merged upstream if they show a significant win (improved performnace, 
> maintaining performance while reducing memory footprint, code hygiene, 
> etc) and there's no specific policy that we cannot make changes to 
> mm/slab.c.

Good.

I see things to improve in SLAB and want to improve it.
I will appreciate if you review them.

Thanks,
Hyeonggon