Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kai Song <songkai01@inspur.com>
To:     <hare@suse.de>, <jejb@linux.ibm.com>, <martin.petersen@oracle.com>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Kai Song <songkai01@inspur.com>
Subject: [PATCH] scsi: fcoe:Use kmemdup() rather than kmalloc+memcpy
Date:   Mon, 4 Oct 2021 14:40:58 +0800
Message-ID: <20211004064058.251899-1-songkai01@inspur.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
tUid:   20211004144059913402333242e805a6f878ef59c8fe95
Abuse-Reports-To: service@corp-email.com
Precedence: bulk

Replace calls to kmalloc followed by a memcpy with a direct 
call to kmemdup.

Signed-off-by: Kai Song <songkai01@inspur.com>
---
 drivers/scsi/fcoe/fcoe_ctlr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index 1756a0ac6f08..37df848e7545 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -1045,11 +1045,10 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
 		if (fip->fcf_count >= FCOE_CTLR_FCF_LIMIT)
 			goto out;
 
-		fcf = kmalloc(sizeof(*fcf), GFP_ATOMIC);
+		fcf = kmemdup(&new, sizeof(*fcf), GFP_ATOMIC);
 		if (!fcf)
 			goto out;
 
-		memcpy(fcf, &new, sizeof(new));
 		fcf->fip = fip;
 		rc = fcoe_sysfs_fcf_add(fcf);
 		if (rc) {
-- 
2.27.0