Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211003000223.25769-1-rdunlap@infradead.org>
In-Reply-To: <20211003000223.25769-1-rdunlap@infradead.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 4 Oct 2021 08:47:35 +0200
Message-ID: <CAMuHMdWxZn85bk9MuMfW1K_k4v68t4duvJtVHgArdqgawxf78Q@mail.gmail.com>
Subject: Re: [RFC PATCH] m68k: set a default value for MEMORY_RESERVE
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Ungerer <gerg@linux-m68k.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Oct 3, 2021 at 2:02 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> 'make randconfig' can produce a .config file with
> "CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
> When a subsequent 'make all' is done, kconfig restarts the config
> and prompts for a value for MEMORY_RESERVE. This breaks
> scripting/automation where there is no interactive user input.
>
> Add a default value for MEMORY_RESERVE. (Any integer value will
> work here for kconfig.)
>
> Fixes a kconfig warning:
>
> .config:214:warning: symbol value '' invalid for MEMORY_RESERVE
> * Restart config...
> Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

As this is relevant for m68knommu, I'll leave it to Greg, unless he's too
busy.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds