Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211001150316.12545-1-andriy.shevchenko@linux.intel.com> <2bee95f7-d54d-5d65-3c9b-91d8db228b09@enneenne.com>
In-Reply-To: <2bee95f7-d54d-5d65-3c9b-91d8db228b09@enneenne.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 4 Oct 2021 10:32:42 +0300
Message-ID: <CAHp75VcP3DCQAbLNXvNzmdB3+sBNNu=_BfkbY5v1c1okX=wOdw@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver()
To:     Rodolfo Giometti <giometti@enneenne.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Alexander Gordeev <lasaine@lvk.cs.msu.su>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 4, 2021 at 9:52 AM Rodolfo Giometti <giometti@enneenne.com> wrote:
>
> On 01/10/21 17:03, Andy Shevchenko wrote:
> > Switch to use module_parport_driver() to reduce boilerplate code.

...

> > -#define DRVDESC "parallel port PPS signal generator"
> > -
>
> I suppose this is not so important to be able to switch to use
> module_parport_driver(), isn't it?
>
> However, aprat this silly note, the patch is OK for me. :)

Thanks! Can you give a formal tag?

-- 
With Best Regards,
Andy Shevchenko