Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp3390906pxb; Mon, 4 Oct 2021 01:01:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAI6Jrg8WoP8c1wIxV8LR+518Bv1C+/CBI5ZW0FAg6B0yy6CLmSjWL+ZQYZHrnVYRVBasW X-Received: by 2002:a50:ed0b:: with SMTP id j11mr6894647eds.260.1633334468296; Mon, 04 Oct 2021 01:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633334468; cv=none; d=google.com; s=arc-20160816; b=jCbsgus5qTxuU3KjchwKPuv9bj4LOsAtNK9/hrQZ3fk+lzVlOLGqMUJDZcOvZClCEB ZTsoqd7AzjYZBukumZLrAC+4b4VhI8K8freO31Yv8AwNyaR8zqTs1y5CPR1+shfq6AhC rfdH/ts9LBiSigPKfD9EAsfSov70fS+tTGQFKnsko0rVusZBFLPml7mKR+1V499zG9Dc 2prTaTF0mnW/fpdOKhcQ832iprPFiuV3hydviuMtkhYEn9ywzG1sJk8B0voJp/Mx4WZR njicTW4pxY+1wMu5CSThzQCdmdhBZwP2BkNeHiGii5EEnzdz75m+AjI7Mx2ImJ6bzYIp dczg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:to:from:subject:message-id; bh=kG6s3dSC7eFfKDtIYq/EKLhSvBVrokum0ZMleQYLeeI=; b=aaiP1+Vma36fcfdGbAuCworjYDhcTZWBqQIa7xIIOFfZAWJyIb/LVuoOeRXFKbLge3 KsOXVP/87ZU5VTEIRKYhy6QOEGmRbriVbEy2k/znnWdJkAeKBwnz0bd4x8wLaNSt8K8j Nx2HTtS8suS5SixgQ6Chb64ShVJLstyaLSucYjqpVgklOb5zxY6TmI0F77Tu9k76eZqm 7v4QcF98t8Of3KE7N2a856OtjyG7j0hBATpr2+WYQMeMXZcu4wwnqDELh2HPBEB6wS9/ GUBVz1HbhhswkVVm9r8B9M9v43PWOpDHgPClxT7gYN0nyNv5/qophhDQXZaUNuHEATZJ aMPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ja20si530788ejc.642.2021.10.04.01.00.43; Mon, 04 Oct 2021 01:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229507AbhJDH4i (ORCPT + 99 others); Mon, 4 Oct 2021 03:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbhJDH4h (ORCPT ); Mon, 4 Oct 2021 03:56:37 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C72C061745 for ; Mon, 4 Oct 2021 00:54:48 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXInv-0000zi-8m; Mon, 04 Oct 2021 09:54:31 +0200 Message-ID: Subject: Re: [PATCH v2 1/5] drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts From: Lucas Stach To: Guido =?ISO-8859-1?Q?G=FCnther?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Sam Ravnborg , Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Mon, 04 Oct 2021 09:54:25 +0200 In-Reply-To: <07ab741922fb158d2ff53cdf26c9c55528d051ce.1633332399.git.agx@sigxcpu.org> References: <07ab741922fb158d2ff53cdf26c9c55528d051ce.1633332399.git.agx@sigxcpu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, dem 04.10.2021 um 09:27 +0200 schrieb Guido Günther: > Components further up in the chain might ask us for supported formats. > > Without this MEDIA_BUS_FMT_FIXED is assumed which then breaks display > output with mxsfb since it can't determine a proper bus format. > > We handle the bus formats that correspond to the DSI formats the bridge > can potentially output (see chapter 13.6 of the i.MX 8MQ reference > manual) - which matches what xsfb can input. > > Fixes: b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if present") > > Signed-off-by: Guido Günther Reviewed-by: Lucas Stach > --- > drivers/gpu/drm/bridge/nwl-dsi.c | 35 ++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c > index a251cc1f088f..27c80d36846b 100644 > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > @@ -1234,6 +1234,40 @@ static void nwl_dsi_bridge_detach(struct drm_bridge *bridge) > drm_of_panel_bridge_remove(dsi->dev->of_node, 1, 0); > } > > +static u32 *nwl_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state, > + u32 output_fmt, > + unsigned int *num_input_fmts) > +{ > + u32 *input_fmts, input_fmt; > + > + *num_input_fmts = 0; > + > + switch (output_fmt) { > + /* If MEDIA_BUS_FMT_FIXED is tested, return default bus format */ > + case MEDIA_BUS_FMT_FIXED: > + input_fmt = MEDIA_BUS_FMT_RGB888_1X24; > + break; > + case MEDIA_BUS_FMT_RGB888_1X24: > + case MEDIA_BUS_FMT_RGB666_1X18: > + case MEDIA_BUS_FMT_RGB565_1X16: > + input_fmt = output_fmt; > + break; > + default: > + return NULL; > + } > + > + input_fmts = kcalloc(1, sizeof(*input_fmts), GFP_KERNEL); > + if (!input_fmts) > + return NULL; > + input_fmts[0] = input_fmt; > + *num_input_fmts = 1; > + > + return input_fmts; > +} > + > static const struct drm_bridge_funcs nwl_dsi_bridge_funcs = { > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > @@ -1241,6 +1275,7 @@ static const struct drm_bridge_funcs nwl_dsi_bridge_funcs = { > .atomic_check = nwl_dsi_bridge_atomic_check, > .atomic_enable = nwl_dsi_bridge_atomic_enable, > .atomic_disable = nwl_dsi_bridge_atomic_disable, > + .atomic_get_input_bus_fmts = nwl_bridge_atomic_get_input_bus_fmts, > .mode_set = nwl_dsi_bridge_mode_set, > .mode_valid = nwl_dsi_bridge_mode_valid, > .attach = nwl_dsi_bridge_attach,