Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH] m68k: set a default value for MEMORY_RESERVE
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>
References: <20211003000223.25769-1-rdunlap@infradead.org>
 <CAMuHMdWxZn85bk9MuMfW1K_k4v68t4duvJtVHgArdqgawxf78Q@mail.gmail.com>
From:   Greg Ungerer <gerg@linux-m68k.org>
Message-ID: <fe79ea3f-0cd0-7a14-65f3-c12e5c5069c0@linux-m68k.org>
Date:   Mon, 4 Oct 2021 17:48:12 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdWxZn85bk9MuMfW1K_k4v68t4duvJtVHgArdqgawxf78Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/10/21 4:47 pm, Geert Uytterhoeven wrote:
> On Sun, Oct 3, 2021 at 2:02 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> 'make randconfig' can produce a .config file with
>> "CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
>> When a subsequent 'make all' is done, kconfig restarts the config
>> and prompts for a value for MEMORY_RESERVE. This breaks
>> scripting/automation where there is no interactive user input.
>>
>> Add a default value for MEMORY_RESERVE. (Any integer value will
>> work here for kconfig.)
>>
>> Fixes a kconfig warning:
>>
>> .config:214:warning: symbol value '' invalid for MEMORY_RESERVE
>> * Restart config...
>> Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Greg Ungerer <gerg@linux-m68k.org>


> As this is relevant for m68knommu, I'll leave it to Greg, unless he's too
> busy.

Thanks Geert. No problem though, I'll pick this up and push to
the m68knommu git tree.

Regards
Greg