Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging: rtl8723bs: core: remove reassignment of same
 value to variable
To:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, marcocesati@gmail.com,
        fmdefrancesco@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
References: <YVnX1HIYoisW621x@user>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <a110ec8f-0b80-1f44-b60f-e0ac62313832@redhat.com>
Date:   Mon, 4 Oct 2021 10:04:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YVnX1HIYoisW621x@user>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 10/3/21 6:18 PM, Saurav Girepunje wrote:
> Remove reassignment of same value to variable pstat->auth_seq.
> On if (seq == 1) assigning the value 2. At the end of if statement
> also assigning the value pstat->auth_seq = seq + 1 that is again
> assigning the value 2.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 3ee4d35ca8d7..059cd85f4b03 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -808,7 +808,6 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame)
>  			pstat->state &= ~WIFI_FW_AUTH_NULL;
>  			pstat->state |= WIFI_FW_AUTH_STATE;
>  			pstat->authalg = algorithm;
> -			pstat->auth_seq = 2;

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


>  		} else if (seq == 3) {
> 
>  			p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len,
> --
> 2.32.0
>