Date: Tue, 19 Dec 2006 15:11:37 -0500 (EST)
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: David Rientjes <rientjes@cs.washington.edu>
cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Get rid of most of the remaining k*alloc() casts.
In-Reply-To: <Pine.LNX.4.64N.0612191158300.21721@attu4.cs.washington.edu>
Message-ID: <Pine.LNX.4.64.0612191505370.11728@localhost.localdomain>
References: <Pine.LNX.4.64.0612190627020.22485@localhost.localdomain>
 <Pine.LNX.4.64N.0612191116170.19395@attu4.cs.washington.edu>
 <Pine.LNX.4.64.0612191436340.11231@localhost.localdomain>
 <Pine.LNX.4.64N.0612191158300.21721@attu4.cs.washington.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1548
Lines: 35

On Tue, 19 Dec 2006, David Rientjes wrote:

> On Tue, 19 Dec 2006, Robert P. J. Day wrote:
>
> > that sounds reasonable but, as i've mentioned before, many of the
> > sizable cleanups i've submitted are produced by a simple script,
> > which is written to process *one* kind of cleanup.  if i tried to
> > fix everything else in the same area at the same time, *that*
> > would involve far more manual labour, not to mention that the
> > patch would be less well-defined, and the probability of a fatal
> > typo would actually increase.

> If these cleanups are being generated by a simple script, I would
> suggest making sure that script works before submitting patches
> which break the kernel.

your point has already been taken.  i'm fairly sure i'm going to make
the occasional screwup, someone will point it out in no uncertain
terms, and i'll fix it.  and life will continue.

> On the other hand, if that script is only being used to point you in
> the direction of a possible cleanup, then it takes very little
> effort to move an asterisk as one person already suggested, get rid
> of whitespace, or make a kzalloc conversion.

all right, if there's some other cleanup that can be done at the
same spot, then i'll put in the effort to do it, as long as it's
within reason.  fair enough?

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/