Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp3572597pxb; Mon, 4 Oct 2021 05:20:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJogTWj7lwtQs/v6rJ+hx9VYGsBvnPLz4fRTlM+UgJtNyEnqFSLjHknTBG7EgDCSfPdspV X-Received: by 2002:a65:5209:: with SMTP id o9mr10560149pgp.63.1633350044935; Mon, 04 Oct 2021 05:20:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633350044; cv=none; d=google.com; s=arc-20160816; b=pO58ydnFanhuqM046OiWvzAWo078Y4SKknZnCF6SxuCrzIqZbzOA7u/AUw/GygWbVj k+wGKhk/HED2Zj5wAu1JIU3IvS2OUY/jxNHMMunOsz6JmLlL6HqIMjs4kGoJS14sVWT1 5Ub7j3lsZQomXVU5Z5A2/0RDb1Mcxk7hRWYrjb8XsVhVj/Fes0QjW6tLZplnuQAkGLTz T8h9vuFPXmaGcRq4R4jL0JzEpok6HnNlaMEBSJii1ytypmVlnFnJljga8q/fMw28nA/v mNsGOoaBZNcgxJeLc7RdiDs4WwgpjRBLCIZj34VT0Scn9NRtkE70TOqeKP1NB38NIzLo 0Hhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=slPbpBqa93SsGSCMOhDQtfscxG5NdChTxcwUXZYbqTU=; b=C5F/i87xesPkeWLihHYNoKEBhLWED1VbK/n2aJvLhduh9yJJs6zayDfSxmVvo24nWs CruYeKGyhid+AyMwS7rilSmoZS9nFjRf9cwy9OCc83WwUZe/kCFqGUl/J26X15ALqo9n acqes7STMC1d9IhTXHCifdHxBLgbAU4sBekpoF47PBtOMgTwVnuolMAABIOMMr1WmNAI xbwc87xc5cCzj20mwGyaodEvhiyhlpuZK4/dD4ilyOcpCmnwwc1L39EmrtZYKiT8bLK4 QjjQH7I7QTQGedcKml2JnJdgSaRzGcoKX/X8VPYq+FX0Vh6CrW6IGuEQyqgteO5FLVRl mUhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=xwjJgSpG; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u13si18484285pju.46.2021.10.04.05.20.32; Mon, 04 Oct 2021 05:20:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=xwjJgSpG; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233054AbhJDLxV (ORCPT + 99 others); Mon, 4 Oct 2021 07:53:21 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:58064 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbhJDLxU (ORCPT ); Mon, 4 Oct 2021 07:53:20 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 731CD201ED; Mon, 4 Oct 2021 11:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1633348290; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slPbpBqa93SsGSCMOhDQtfscxG5NdChTxcwUXZYbqTU=; b=xwjJgSpGv375/UWbWLOIKrpSZ/XrQrcWwJ8PVOLSyTPYdqbcsDwYRdxgnbiKTMyRYMdIEC VsOqLrnV8iroMNxtQj3fScjxL7BXYUBrMdkDU7UWAL75CG++BBGDIzGqeK5N3cLjcYJXjj GPaVu3ugsXPkgidtjGL6yq1JNNWLJ+U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1633348290; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slPbpBqa93SsGSCMOhDQtfscxG5NdChTxcwUXZYbqTU=; b=RuSo0qsJJ6KI9zkcSz6VmBkFR4bWqc07RfKEOupJaKXWoYNu0MdVZR8VudDRvTr1TukjeG 9dfK3MlLmph++fDA== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id 4DE94A3B81; Mon, 4 Oct 2021 11:51:30 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 1D748DA7F3; Mon, 4 Oct 2021 13:51:11 +0200 (CEST) Date: Mon, 4 Oct 2021 13:51:11 +0200 From: David Sterba To: Hamza Mahfooz Cc: linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: use kmem cache to allocate struct btrfs_qgroup_extent_record Message-ID: <20211004115110.GW9286@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Hamza Mahfooz , linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org References: <20211004105533.1605-1-someguy@effective-light.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004105533.1605-1-someguy@effective-light.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 04, 2021 at 06:55:32AM -0400, Hamza Mahfooz wrote: > Commit 3368d001ba5d ("btrfs: qgroup: Record possible quota-related extent > for qgroup.") suggests that, The commit is from 2015 and besides the TODO notice there's nothing that explains why it should be kmem cache and not plain kmalloc/kfree. So, why you'd like to do the change?