Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Yicong Yang <yangyicong@hisilicon.com>, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, 21cnbao@gmail.com
Cc:     linux-kernel@vger.kernel.org, song.bao.hua@hisilicon.com,
        prime.zeng@huawei.com, yangyicong@hisilicon.com
Subject: Re: [RESEND PATCH] sched/topology: Remove unused numa_distance in cpu_attach_domain()
In-Reply-To: <20210915063158.80639-1-yangyicong@hisilicon.com>
References: <20210915063158.80639-1-yangyicong@hisilicon.com>
Date:   Mon, 04 Oct 2021 16:20:39 +0100
Message-ID: <87y278lsu0.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 15/09/21 14:31, Yicong Yang wrote:
> numa_distance in cpu_attach_domain() is introduced in
> commit b5b217346de8 ("sched/topology: Warn when NUMA diameter > 2")
> to warn user when NUMA diameter > 2 as we'll misrepresent
> the scheduler topology structures at that time. This is
> fixed by Barry in commit 585b6d2723dc ("sched/topology: fix the issue
> groups don't span domain->span for NUMA diameter > 2") and
> numa_distance is unused now. So remove it.
>

Ah, 585b6d2723dc didn't contain a proper revert of b5b217346de8, leaving
those hunks behind.

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>