Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <1633330133-29617-4-git-send-email-pillair@codeaurora.org>
References: <1633330133-29617-1-git-send-email-pillair@codeaurora.org> <1633330133-29617-4-git-send-email-pillair@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.9.1
Date:   Mon, 4 Oct 2021 14:35:56 -0400
Message-ID: <CAE-0n51cMX95kuuFUAusqhFOUUZeGsGfA_=5u+5O8w1C=toLzA@mail.gmail.com>
Subject: Re: [PATCH v6 3/3] remoteproc: qcom: q6v5_wpss: Add support for
 sc7280 WPSS
To:     Rakesh Pillai <pillair@codeaurora.org>, agross@kernel.org,
        bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
        ohad@wizery.com, p.zabel@pengutronix.de, robh+dt@kernel.org
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, sibis@codeaurora.org,
        mpubbise@codeaurora.org, kuabhs@chromium.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting Rakesh Pillai (2021-10-03 23:48:53)
> Add support for PIL loading of WPSS processor for SC7280
> - WPSS boot will be requested by the wifi driver and hence
>   disable auto-boot for WPSS.
> - Add a separate shutdown sequence handler for WPSS.
> - Add multiple power-domain voting support
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

This changed? Please don't keep reviewed-by if things changed
significantly.

> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> index 098362e6..b6d3c3d 100644
> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> @@ -531,15 +685,40 @@ static const struct adsp_pil_data cdsp_resource_init = {
>         .ssr_name = "cdsp",
>         .sysmon_name = "cdsp",
>         .ssctl_id = 0x17,
> +       .is_wpss = false,
> +       .auto_boot = true,
>         .clk_ids = (const char*[]) {
>                 "sway", "tbu", "bimc", "ahb_aon", "q6ss_slave", "q6ss_master",
>                 "q6_axim", NULL
>         },
>         .num_clks = 7,
> +       .proxy_pd_names = (const char*[]) {
> +               "cx", NULL
> +       },
> +};
> +
> +static const struct adsp_pil_data wpss_resource_init = {
> +       .crash_reason_smem = 626,
> +       .firmware_name = "wpss.mdt",
> +       .ssr_name = "wpss",
> +       .sysmon_name = "wpss",
> +       .ssctl_id = 0x19,
> +       .is_wpss = true,
> +       .auto_boot = false,
> +       .load_state = "wpss",
> +       .clk_ids = (const char*[]) {
> +               "gcc_wpss_ahb_bdg_mst_clk", "gcc_wpss_ahb_clk",
> +               "gcc_wpss_rscp_clk", NULL

Please remove "gcc_wpss_" prefix and "_clk" postfix. Does that make this
match the binding?

> +       },
> +       .num_clks = 3,
> +       .proxy_pd_names = (const char*[]) {
> +               "cx", "mx", NULL
> +       },
>  };
>