Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V3 4/9] fork: add option to not clone or dup files
Date:   Mon,  4 Oct 2021 14:21:23 -0500
Message-Id: <20211004192128.381453-5-michael.christie@oracle.com>
In-Reply-To: <20211004192128.381453-1-michael.christie@oracle.com>
References: <20211004192128.381453-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hBddA39DV5kxT2Dw/in2mtYbqpOP6QO1o7uDw8eTqyKhHOzwLnq8rSohQujb?=
 =?us-ascii?Q?FkzBjDhokfg/K8lqfAuzLJlzwHgNLdGHvixCl1Pwlw3c+YSKtUvcwwxnblk0?=
 =?us-ascii?Q?B8HtNCfqUCcb805W/Bshhj+KbgV61tJUjBoUfMjveBOwoAbVwhfcKL5Md2nF?=
 =?us-ascii?Q?v6c08RibOBww0KyI2oJ/s5Pt5rFZnP9CcOURgWJcUpV3XSwy0fhnpQhojDi+?=
 =?us-ascii?Q?EBwBMbKAOAJWyLXRvQf/Y3kjlMcun42BASZjESqQk72nBJfqZMWA5Qdu2mkp?=
 =?us-ascii?Q?y7MNCjRIdlWmHoVfNj/+2AjYVf4zMi+k/BzsC20qgksc/TJuSe/iZguesq2e?=
 =?us-ascii?Q?/uTtXEb59G8B3J8D+p2BwtgUEnB2sTn6nbl4bWPY29kFPNlkhKs5tkBoyUI+?=
 =?us-ascii?Q?3tpX2YPCwkkAyHzCLfjLDvD8rW/j1fRRNfREqhbqhWb+kV4Z8C8DvNTPy+Iz?=
 =?us-ascii?Q?NXmoOf3cKOutAtEjNstiIo5DL3iH0tSvOMTH0AeEwveKKmd5cRs+l4Tu4EWS?=
 =?us-ascii?Q?BVqkh6RrgYSNky+xA3pphITI1x3xmjqcUFVYWkshGGtr/9k/5ZYMHpeRV7WZ?=
 =?us-ascii?Q?bqe+UhCiWY9+MNeyJtIKHe0CTKHhVPIxGxFGOD0tRuu1S1WfgkQCd/zRkC38?=
 =?us-ascii?Q?3ivyP1SgGXA+pz6/dLKB0bbdQPo+F7v5vf+1iFJ8C286gWcoDJKJ+RPweAfW?=
 =?us-ascii?Q?GTE35lqhaENbzK7ohWKtr4bIb31RK7dN8WXniKM5EV60LEHfuopi5HDuJMGH?=
 =?us-ascii?Q?/Yj6w3mU9Wx1r7ubza+O5e1xcgV/2pw+QjiwmI/oLSzU7quJkMXfb7NKtGXd?=
 =?us-ascii?Q?yf3eNbQHP78DIMIOXE/zgYj1r1ekP3ZduHbTLGm8iUPZwv3H9e5yQDqSn7OR?=
 =?us-ascii?Q?BJ9ndY3T+BC9wVNksPPHgPghe7YVkhLtecxsLD0+DHHCHc0ntT1F65yePwSj?=
 =?us-ascii?Q?YVPCtTqcKzt2+EZIduTB5SdMjHxKKJguMlskiCZIrYZvVCv3XkiVTktugh9H?=
 =?us-ascii?Q?yNhc31sNeI3TdF9Jb7lDWNWEdBwVIfKZvEycn28NVsP4EQiaC3XGEAeKzB2I?=
 =?us-ascii?Q?mwkD3wcUmgKg6MHna3CKojGC+sW5sn7SyE3hTd9kEBcoE22SZCS230trop3M?=
 =?us-ascii?Q?skZptTZm+QBdZ6X0DqVgYfxgDaxKZPjANs/Pg5oP5XA3C/tTz0zsiEIRISzj?=
 =?us-ascii?Q?rValpKr0dJ1/K+SVAFr3MxP98DWhNnEmsQrhDIRxl1zhvyQZyFPI2FTQaYXD?=
 =?us-ascii?Q?Hxliz8bsddZ7H1LXunrdiFPpbcJjP7UtIP+r57CgjCkc4eyoGFN/+I1pTu8v?=
 =?us-ascii?Q?paNfudA7SWJ3V91m6NYFcUbD?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33eecfd0-629f-49ee-34c2-08d9876c30f4
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 19:21:39.9513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CUxQccJktKcaTYq2YoJ6X6cSZU7/ggYoM/1gEyjIwfJMMiAIpRhnQIT0vGlYveUbLnKMW6Si+aP1Jzr0J9ppW4iMBaoSx+/jveJbcxf9hWs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1548
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10127 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110040131
X-Proofpoint-GUID: tTaJp9WeRUNuDrkxcwix7o1PLY9Es-g2
X-Proofpoint-ORIG-GUID: tTaJp9WeRUNuDrkxcwix7o1PLY9Es-g2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it calls the kernel_worker() function added in
the next patch we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index cf7c9fffc839..e165cc67fd3c 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define KERN_WORKER_IO		BIT(0)
 #define KERN_WORKER_USER	BIT(1)
+#define KERN_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 4b0e8257993b..98264cf1d6a6 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1532,7 +1532,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1544,6 +1545,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2179,7 +2185,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & KERN_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1