Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V3 7/9] fork: Add worker flag to ignore signals
Date:   Mon,  4 Oct 2021 14:21:26 -0500
Message-Id: <20211004192128.381453-8-michael.christie@oracle.com>
In-Reply-To: <20211004192128.381453-1-michael.christie@oracle.com>
References: <20211004192128.381453-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fb1o2BP1/EXevwYNxePdt0LbtrB4i1vInrHg2iCVgpZpKDEwHemHfTZ8+pzm?=
 =?us-ascii?Q?aMRmK/Qbb6EpGQC0iXswzt88WdcYhIW2YTbhZynk3JqI9SAuxBEC79/8KT6U?=
 =?us-ascii?Q?NWsDRs1f4a+7CMxvVUPLWy6LAGr8zY11lSYHAX+u8pjSmotXdHxL8LzcvOwC?=
 =?us-ascii?Q?mOJLeeJD7g7WvcwoqOP70lnHmqvlDx2XMbIWDQSevVssm/+AzDF1arV4n9B9?=
 =?us-ascii?Q?2id/1Lhj/ExsSZqxiDuWn6b2jt4Iv0bbLsHf9j92VSkVzT0My2thgQoaFoLh?=
 =?us-ascii?Q?PMScU/mddsMeC+nZosLCVeoBPdnj4uJcjsoWmo1txQ4HzwEXR2jTsmF8mBB1?=
 =?us-ascii?Q?TM3jtwtB/rnuWNlqOn+UO8YOj//LGlV6wsI7YhuqOAmGxwqbIX2hKoZeXBqE?=
 =?us-ascii?Q?k6MMxKv/qWEh1nbn705jebpw/VKb95ZwXuk3EKS0jlUsiMFHIaPO8tHO6Djl?=
 =?us-ascii?Q?dR9jf+8MdAptvMXIWV1jWfqyFZcUrdUwECWUcY/XAw/bTPkcxmhpU5vWitrP?=
 =?us-ascii?Q?iyZDsewliTTPNB7eFuo+sBa2vZgfVuEi70AdWfMGDPwHAJOg7PoeHlnbm9qm?=
 =?us-ascii?Q?g3982ossxO0Mv1fK+8b76dM/17nfSQ6UkpEWyiEgYRoumn82Ku2Py4n/6J1K?=
 =?us-ascii?Q?Zlxyltcm1nkv6pNgFSqvMSgAf4wzyKc5yRdsJPLNNmvgW1l9PuMpjbGQ11DH?=
 =?us-ascii?Q?GpVgmsRBwzq3iau0W0fCMxrGgEua+OPRy9NIPCz9nucthcvjh7SPc7W0cizw?=
 =?us-ascii?Q?y+Ci9uconvXfan1MhknhP+Rupmpcpo+f+VLbMnf1CC/8dw/Ns+0wC89MnUvE?=
 =?us-ascii?Q?CFYJ4m1MpmFTVkURw3NjO6d5JXYnI85SA4Z7doCStTOqYd6aFwxYDLUL7j3H?=
 =?us-ascii?Q?lwRTjxcvBiUJ7see6HZ4LvYsE5TXrqdeUsAKKtw0FPl8JBHjYRUPbQM3QWtE?=
 =?us-ascii?Q?IupxN6v8d76kaN0NhLMung4dRBLZ0P3rOz5ZvOSTooWzcTVjxZ/usAO3IjLN?=
 =?us-ascii?Q?hrQG+/ScLIw7+23cY7w6y/KTD8EfkYnqeEo5oCrWE6bUK4pTLjCR21rxfcyd?=
 =?us-ascii?Q?8TpiwoRhBeOuYzi3nnlmWyuNF8huukw9jKIYz3FDJNyzx9o318lQtStmGiEF?=
 =?us-ascii?Q?vTiHAOfOTK3QTiNGbAzDsNuS7IhF2vkMNiFHLPOQtxengqYHm8ELkefdzHTS?=
 =?us-ascii?Q?FPzOLHVVIC6PXj2KivgN63O3KFDumDwpXhk1hLas2RLYL+4euF6b1tUKT8mf?=
 =?us-ascii?Q?m+ouli0I56wmkYTM0OvJCn4e7ERJ0PchKhK+GMDd27bZaBvH9fnSWPrrnMHN?=
 =?us-ascii?Q?QOia4xu75dLimQ9TNB4TzDaQ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe0a153b-0cb9-4213-ffa2-08d9876c3264
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 19:21:42.2812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eaIprhTByqsLVm1EcW/mitElPCI+/WpuYcHFwGHQsssxUwu3L4w4jpgzN2MCSxJuviDCPoEYhnc4SdCwy53XtmkUgGHlar8NisBfJDExhiU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1548
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10127 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110040131
X-Proofpoint-GUID: jXxhT5Pc-wXPFq5CUUyMxu6dFucHhroT
X-Proofpoint-ORIG-GUID: jXxhT5Pc-wXPFq5CUUyMxu6dFucHhroT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The kthread API creates threads that ignore all signals by default so
modules like vhost that will move from that API to kernel_worker will
not be expecting them. This patch adds a worker flag that tells
kernel_worker to setup the task to ignore signals.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 781abbc1c288..aefa0d221b57 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -21,6 +21,7 @@ struct css_set;
 #define KERN_WORKER_IO		BIT(0)
 #define KERN_WORKER_USER	BIT(1)
 #define KERN_WORKER_NO_FILES	BIT(2)
+#define KERN_WORKER_NO_SIGS	BIT(3)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 3f3fcabffa5f..34d3dca70cfb 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2555,6 +2555,8 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
 struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node,
 				  unsigned long clone_flags, u32 worker_flags)
 {
+	struct task_struct *tsk;
+
 	struct kernel_clone_args args = {
 		.flags		= ((lower_32_bits(clone_flags) | CLONE_VM |
 				   CLONE_UNTRACED) & ~CSIGNAL),
@@ -2564,7 +2566,14 @@ struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node,
 		.worker_flags	= KERN_WORKER_USER | worker_flags,
 	};
 
-	return copy_process(NULL, 0, node, &args);
+	tsk = copy_process(NULL, 0, node, &args);
+	if (IS_ERR(tsk))
+		return tsk;
+
+	if (worker_flags & KERN_WORKER_NO_SIGS)
+		ignore_signals(tsk);
+
+	return tsk;
 }
 EXPORT_SYMBOL_GPL(kernel_worker);
 
-- 
2.25.1