Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211002231723.29019-1-ammar.faizi@students.amikom.ac.id> <20211004090524.GS2048@kadam>
In-Reply-To: <20211004090524.GS2048@kadam>
From:   Ammar Faizi <ammar.faizi@students.amikom.ac.id>
Date:   Mon, 4 Oct 2021 21:11:00 +0700
Message-ID: <CAGzmLMVMmzcP3ih33QhxOBbiqBZRgfiz6ke5K6UMcSeope8Jag@mail.gmail.com>
Subject: Re: [PATCH] media: atomisp: fix `-Werror=return-type`
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Pavel Skripkin <paskripkin@gmail.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org,
        Bedirhan KURT <windowz414@gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 4, 2021 at 4:06 PM Dan Carpenter <dan.carpenter@oracle.com> wro=
te:
>
> On Sun, Oct 03, 2021 at 06:17:23AM +0700, Ammar Faizi wrote:
> > Bedirhan reported build error:
> > ```
> >   drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_syst=
em.c: In function =E2=80=98input_system_configure_channel_sensor=E2=80=99:
> >   drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_syst=
em.c:1649:1: error: control reaches end of non-void function [-Werror=3Dret=
urn-type]
> >    1649 | }
> >         | ^
> >   cc1: some warnings being treated as errors
> >   make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomi=
sp/pci/hive_isp_css_common/host/input_system.o] Error 1
> >   make[3]: *** [scripts/Makefile.build:540: drivers/staging/media/atomi=
sp] Error 2
> >   make[2]: *** [scripts/Makefile.build:540: drivers/staging/media] Erro=
r 2
> >   make[1]: *** [scripts/Makefile.build:540: drivers/staging] Error 2
> >   make: *** [Makefile:1868: drivers] Error 2
> > ```
> >
> > Commit 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp:
> > remove useless returns") incorrectly removed a required return results
> > in the above build error. Reinstate it.
> >
> > Cc: Pavel Skripkin <paskripkin@gmail.com>
> > Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-staging@lists.linux.dev
> > Cc: linux-kernel@vger.kernel.org
> > Reported-by: Bedirhan KURT <windowz414@gnuweeb.org>
> > Fixes: 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp: remov=
e useless returns")
> > Signed-off-by: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
>
> What's going on with this?  It's like the seventh time people have sent
> a fix for it?  Why are you not using against a current tree?
>
> regards,
> dan carpenter
>

Sorry for the duplicate. It broke my build. I am using Linus' tree
5.15-rc4, the error still lives here. My mistake, I didn't check the
linux-next tree before sending this fix.

--=20
Ammar Faizi