Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 Oct 2021 21:04:21 +0200
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Max Gurtovoy <mgurtovoy@nvidia.com>
Cc:     hch@infradead.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, linux-pci@vger.kernel.org,
        bhelgaas@google.com, stefanha@redhat.com, oren@nvidia.com
Subject: Re: [PATCH v3 2/2] PCI/sysfs: use NUMA_NO_NODE macro
Message-ID: <YVtQNSoCJG5cJb4b@rocinante>
References: <20211004133453.18881-1-mgurtovoy@nvidia.com>
 <20211004133453.18881-2-mgurtovoy@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211004133453.18881-2-mgurtovoy@nvidia.com>
Precedence: bulk

Hi Max!

> Use the proper macro instead of hard-coded (-1) value.
> 
> Suggested-by: Krzysztof Wilczyński <kw@linux.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>  drivers/pci/pci-sysfs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 7fb5cd17cc98..f807b92afa6c 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -81,8 +81,10 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,
>  	const struct cpumask *mask;
>  
>  #ifdef CONFIG_NUMA
> -	mask = (dev_to_node(dev) == -1) ? cpu_online_mask :
> -					  cpumask_of_node(dev_to_node(dev));
> +	if (dev_to_node(dev) == NUMA_NO_NODE)
> +		mask = cpu_online_mask;
> +	else
> +		mask = cpumask_of_node(dev_to_node(dev));
>  #else
>  	mask = cpumask_of_pcibus(to_pci_dev(dev)->bus);
>  #endif
> -- 
> 2.18.1

Thank you!

	Krzysztof