Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 Oct 2021 16:52:24 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Lijun Ou <oulijun@huawei.com>, Weihang Li <liweihang@huawei.com>,
        Doug Ledford <dledford@redhat.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/hns: Use dma_alloc_coherent() instead of
 kmalloc/dma_map_single()
Message-ID: <20211004195224.GA2576309@nvidia.com>
References: <20210926061116.282-1-caihuoqing@baidu.com>
 <20210927115913.GA3544071@ziepe.ca>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210927115913.GA3544071@ziepe.ca>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kuYilCKAhnmz1JwyqfTzgdqR1CvZxsdK5+kDrO4g8bHNtUIPZFfKwT4XIKFi?=
 =?us-ascii?Q?GOpCQZYoPXMcz04YqIqJidz4scNG/en4umm1r+yXlmf6r1BY3xGIml5dNjHv?=
 =?us-ascii?Q?Ufg6OW457kX76UdaCrepse6W7p6NK0ZmQukSS3qqXs8ck4heKmE7klFfnW1X?=
 =?us-ascii?Q?E8ha7McVt4rL2I++L0E5DbyVK3JbNmeVvH1QtbsakY/HUjM2H6+/qfsEewXx?=
 =?us-ascii?Q?zEkiFN/ip0OCtMe/WmWtflF1tivTnS6ebzs7CEmygdqRl7E0Y59Y5TeP0Oe0?=
 =?us-ascii?Q?aPAHdu+QspRgqCUVsDFwebdmr2FwY6RuTcpXM0UEFaH2hO+ImqsAcfy5rEdz?=
 =?us-ascii?Q?Z4H6lIcXlSYDstBmbdeoiB8E7mHRMjoblAZ/WeAtVpqRweklnq+XRgc3Omyf?=
 =?us-ascii?Q?uCSbGbSIRIBJvWUsyHmtTd9IrlienJrpOTQZPLkxu8dya2RuirdTS1rFQ2iL?=
 =?us-ascii?Q?BpbaGkLz4TNGLnaFcGA7NTA3nshjC4I6u/Rb6MEbqJ7a5aPmieh3m2QYQqxW?=
 =?us-ascii?Q?ECnsDVVpdcVOcXmCMn8vx+uFeHHrIOaMAxEtEFftCtztUJhvhqWVlCsyry7c?=
 =?us-ascii?Q?32WvmLeAe+X48fTeivTDtD45BAz84Z/C0qZu13BhIoTaNTpBaV6IfbJjH3sa?=
 =?us-ascii?Q?eyKcd5FVARvpFPKKG3zv3eckiq0FuURTsUufHe66gMZT590as24LuNCG5xRm?=
 =?us-ascii?Q?I5KVyvFB/fbhZnndjXRcIjmxy72n8OqjQaqQTIGhtqUkqBGCBNa0mAeooLeR?=
 =?us-ascii?Q?yb7TNfdYjKQXK8Ri8WKM+DPOrCkdS85QjkN1dEWvRmHriGNm75FSrb44UXUV?=
 =?us-ascii?Q?oIVLbd8HtT5037NcgidhAkfP8DZWciju/nfIhiyecg0WYnzcHaYE9B52PZHw?=
 =?us-ascii?Q?JOFZ6xyNBB6jCCJCdCSIBhA4vfaIaLJGCiEQvp63NHfIVX001bIl8cKssZnS?=
 =?us-ascii?Q?Xp5oEW2zYS157M9+gtMvwtRqhxtYDHsvo+STJ+hCXq9O52AQR7A0XT9GIz5e?=
 =?us-ascii?Q?hciBBdANkbNFIVh4J7s9Snwux4HaCOZaGGK9XemAAe/6PM39kGqdwAs+QxmN?=
 =?us-ascii?Q?Vm7FctY0buBnGNLIqJjMcxZ9rltD8EdbpWMd9cNxWsptaDYZclWL5KVQuka2?=
 =?us-ascii?Q?ULlONHQ+Uzo8N40VO3/BNClyZy+D3lafxdTkk+kWIq3HQ5H+PzUSZM7HvGdK?=
 =?us-ascii?Q?3p3Rijdq2fxGm4pGWDw1ZOZhUipo7xna3F/IyOWo6KWdEcw8oftBG0Iqko6Q?=
 =?us-ascii?Q?oo2WOH3mhL9DUCFyhlUfSNwNCWjwfDkO2lgKOakHTByj7QJz3VoW3Ohu92X6?=
 =?us-ascii?Q?U7Le8fS2GzpbndpgH95y4FCNgjjVainxc6XsPj2Ie0L8JA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bf58461-db4d-4ea3-e58a-08d987707d48
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 19:52:26.0539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lNs/zUX9kLhW7PKk8t2kUx6VFM/u+6+DHBXzNVpcm/+21U9C1rnVQrLTGuHsIESX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5128
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 27, 2021 at 08:59:13AM -0300, Jason Gunthorpe wrote:
> On Sun, Sep 26, 2021 at 02:11:15PM +0800, Cai Huoqing wrote:
> > Replacing kmalloc/kfree/dma_map_single/dma_unmap_single()
> > with dma_alloc_coherent/dma_free_coherent() helps to reduce
> > code size, and simplify the code, and coherent DMA will not
> > clear the cache every time.
> > 
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> >  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 20 +++++---------------
> >  1 file changed, 5 insertions(+), 15 deletions(-)
> 
> Given I don't see any dma_sync_single calls for this mapping, isn't
> this a correctness fix too?

HNS folks?

Jason