Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to
 the right controller"
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Felipe Balbi <balbi@kernel.org>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>
References: <20211004141839.49079-1-andriy.shevchenko@linux.intel.com>
From:   Ferry Toth <fntoth@gmail.com>
Message-ID: <7019ca3e-f076-e65b-f207-c23a379ade29@gmail.com>
Date:   Mon, 4 Oct 2021 22:35:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211004141839.49079-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi,

Op 04-10-2021 om 16:18 schreef Andy Shevchenko:
> The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right
> controller") changed the device for the UDC and broke the user space scripts
> that instantiate the USB gadget(s) via ConfigFS.

I confirm this regression on Intel Edison since at least 5.15-rc2 while 
in 5.14.0 it was working fine.

This patch resolves the issue as tested on 5.15-rc4.

Tested-by: Ferry Toth<fntoth@gmail.com>

> Revert it for now until the better solution will be proposed.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/usb/dwc3/gadget.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 8e66a70adae6..13664609ed3c 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4253,7 +4253,7 @@ int dwc3_gadget_init(struct dwc3 *dwc)
>   	}
>   
>   
> -	usb_initialize_gadget(dwc->sysdev, dwc->gadget, dwc_gadget_release);
> +	usb_initialize_gadget(dwc->dev, dwc->gadget, dwc_gadget_release);
>   	dev				= &dwc->gadget->dev;
>   	dev->platform_data		= dwc;
>   	dwc->gadget->ops		= &dwc3_gadget_ops;