Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kim Phillips <kim.phillips@amd.com>
To:     Arnaldo Carvalho de Melo <acme@redhat.com>, kim.phillips@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Ian Rogers <irogers@google.com>,
        Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Robert Richter <robert.richter@amd.com>,
        Stephane Eranian <eranian@google.com>
Subject: [PATCH 2/2] perf tools: Improve IBS error handling
Date:   Mon,  4 Oct 2021 16:41:14 -0500
Message-Id: <20211004214114.188477-2-kim.phillips@amd.com>
In-Reply-To: <20211004214114.188477-1-kim.phillips@amd.com>
References: <20211004214114.188477-1-kim.phillips@amd.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WgYq4JsjW1Hsbf+uByH1QaHihoEGND8uZvW/hzRX2VeupqsyEfeTYkOkfYLB?=
 =?us-ascii?Q?ckiiuLPtwiKhgfeelzEtP84TwFRmeP6IUdxVgCKrjvzOW5Pduo3YlXftC7CM?=
 =?us-ascii?Q?j5/H36C1YyuDoWGDzWppRBp20WrSMfhIjTrabPIDaDQZAwNhKprR/xunwVzG?=
 =?us-ascii?Q?baA97dMg+Kc65CjB00mtU0EkYNOterhxzvfRi8ilfD/2vw61KxNHPcNki7Kp?=
 =?us-ascii?Q?o6zbZHIn898sRrM5e1B6E1KeB/8neh3fbkLFXITqklW5npBuKnzee/RffJ9y?=
 =?us-ascii?Q?jffPaiiaADZCEnn4Q1oyOlfyHdzNGYFPcas09JUmw9hxsY6p0GDmtiy4piYn?=
 =?us-ascii?Q?W3aA8b8lJWm7EpBHvqqpeTpgLpsH8XeRWm3Vnb7ZQ8fhgXD0zPPx42j4UgqW?=
 =?us-ascii?Q?6FB5APIqTl7KnuDWeWH+62wDPdsTvIXXx6+73z7kmtlKx9Gw+oAHkuTwm47B?=
 =?us-ascii?Q?1g0o1yIvVm4l/F8vF7v2KMglbtS+dmlUAft0k0OyhMh69dyIThf01iDl8wSn?=
 =?us-ascii?Q?336NZ8VO3hq5U9f6K8UI6m7ZlOT2IJ6RBhRbIN3m+KeX1AEAMLlfMINAOBBl?=
 =?us-ascii?Q?taIsl2Otvt30Ek3IOR24gN1HdDapmgtkfse3AL757yqvle6A5xR3mHhox+xb?=
 =?us-ascii?Q?5443woc4xyMN8zruUHeRTLJhsQhu3SuooWxK9qec20s6tPh9hElLvGZ7Kf1g?=
 =?us-ascii?Q?lIke3M9aZdnRPT/lCJkBA9W60lxb89AKZbH0kNbbOhvlQzF0qXdApu2/oDmt?=
 =?us-ascii?Q?Ze8A7aQTAwyYk0uwmQ1YWiWGwNPQmD7vQzURt1Za9QsdejT1qWr0wSGo8Rv1?=
 =?us-ascii?Q?3aTWSN8H6FfcOgRZB6kt62DNm8BwzzNlQFMHIpgBiFBjDvnM/XxNbCkZLbrU?=
 =?us-ascii?Q?AdoaCtlZsOSSFa9r/Q99IEX2Vpbw3GWc9SUiyGQmME7M31dhYrR5iOJYH75d?=
 =?us-ascii?Q?Xmg3O8qksjyZI37RywXpwUcN4ZTcBz5TRbmY0CWKOcTNDY35bZClzerMx+Lt?=
 =?us-ascii?Q?wkdlbqMAWIK8pOL//uPT09i3KfXRn4MpU74FGfSCJ+ezEnG1S04oecNe77XU?=
 =?us-ascii?Q?olaNwHX7wlOR0iXoeiBkxi5VssrXWic939fjaA6JhZ1FX1hmJTZUCTL3QkjO?=
 =?us-ascii?Q?gQeiOPkgtMA9dyIA5ZGKtGTcnU+mCQvLYx+kF5JD3f9mRojX/lFtvPRsiCl5?=
 =?us-ascii?Q?z80IhjzCt06DNcQ22oY+bvgmFYyhN0V+qPkHHIfS7+5iq1cZ1F88IbtivZyb?=
 =?us-ascii?Q?lmwTtn7K5goIQT4aBfLoG+7rd7DFP0BgZDIBm2OirtCQeG8Nf0QxnUKFnVwb?=
 =?us-ascii?Q?+iWCA8pcknz51Mz3V6C+IDO8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79709a7d-4914-47cf-b995-08d9877fc2c7
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3505.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 21:41:44.9250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uk/jL7sdzctHI9W+zMfShEouYKcH+ON1X+W8usF5fcNgAT9DujwxEQur3CpJ+H9oWnf3clKfgIEmyAB9DU1BuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2772
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch improves the error message returned on failed
perf_event_open() on AMD when using IBS.

Output of executing 'perf record -e ibs_op// true' BEFORE this patch:

The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (ibs_op//u).
/bin/dmesg | grep -i perf may provide additional information.

Output after:

AMD IBS can't exclude kernel events.  Try running at a higher privilege level.

Output of executing 'sudo perf record -e ibs_op// true' BEFORE this patch:

Error:
The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (ibs_op//).
/bin/dmesg | grep -i perf may provide additional information.

Output after:

Error:
AMD IBS may only be available in system-wide/per-cpu mode.  Try using -a, or -C and workload affinity

Signed-off-by: Kim Phillips <kim.phillips@amd.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Joao Martins <joao.m.martins@oracle.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Stephane Eranian <eranian@google.com>
---
 tools/perf/util/evsel.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index b915840690d4..f8a9cbd99314 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2743,9 +2743,22 @@ static bool find_process(const char *name)
 	return ret ? false : true;
 }
 
+static bool is_amd(const char *arch, const char *cpuid)
+{
+	return arch && !strcmp("x86", arch) && cpuid && strstarts(cpuid, "AuthenticAMD");
+}
+
+static bool is_amd_ibs(struct evsel *evsel)
+{
+	return evsel->core.attr.precise_ip || !strncmp(evsel->pmu_name, "ibs", 3);
+}
+
 int evsel__open_strerror(struct evsel *evsel, struct target *target,
 			 int err, char *msg, size_t size)
 {
+	struct perf_env *env = evsel__env(evsel);
+	const char *arch = perf_env__arch(env);
+	const char *cpuid = perf_env__cpuid(env);
 	char sbuf[STRERR_BUFSIZE];
 	int printed = 0, enforced = 0;
 
@@ -2841,6 +2854,17 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
 			return scnprintf(msg, size, "wrong clockid (%d).", clockid);
 		if (perf_missing_features.aux_output)
 			return scnprintf(msg, size, "The 'aux_output' feature is not supported, update the kernel.");
+		if (is_amd(arch, cpuid)) {
+			if (is_amd_ibs(evsel)) {
+				if (evsel->core.attr.exclude_kernel)
+					return scnprintf(msg, size, 
+	"AMD IBS can't exclude kernel events.  Try running at a higher privilege level.");
+				if (!evsel->core.system_wide)
+					return scnprintf(msg, size,
+	"AMD IBS may only be available in system-wide/per-cpu mode.  Try using -a, or -C and workload affinity");
+			}
+		}
+
 		break;
 	case ENODATA:
 		return scnprintf(msg, size, "Cannot collect data source with the load latency event alone. "
-- 
2.31.1