Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC net-next PATCH 08/16] net: macb: Clean up macb_validate
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>
References: <20211004191527.1610759-1-sean.anderson@seco.com>
 <20211004191527.1610759-9-sean.anderson@seco.com>
 <YVuIcqKjDgawNPG4@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <b88da591-5cf9-dcb8-bc7c-e6198868e6ee@seco.com>
Date:   Mon, 4 Oct 2021 19:09:15 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YVuIcqKjDgawNPG4@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWV1MTNPUG0yVWQ3NDYra0RjYnVvNDFIcTR2b1FHdkFvR0NYRXMzSEF0RXFn?=
 =?utf-8?B?SENGcU90VzVrb21CM2t4VUxiQXhFSzAwY3RVcnEvUEgxTDFCdTVtSDBLYlFh?=
 =?utf-8?B?OVJGWmY4Ym9kNFRYVVoxNENzRzc1QUpQY3JWUEhFeCtWQ1pra2F0RnZDN0Rr?=
 =?utf-8?B?OU5oaHBPNS9XMElUbERsS2JONkhXblc0RWVIOGNpQW1tZzlrRWVtajd2VDYy?=
 =?utf-8?B?aE1kb0YrWGh3WC95ZllVSVVFSHoyMzVseXRiRlp4ZGY4Uy9BOEgvRHRyZldG?=
 =?utf-8?B?M0R6QWIvWEVvL3FqU2VxOURpVmxGakhVbXNUS3VqeXAvRHlhSXVNRHZpL1dn?=
 =?utf-8?B?MDFpMENXK3pVQkdxNlBsZzUyaHIyRS8xYXU3dFJDWlQvT2hxdm53YmY3Y0Iw?=
 =?utf-8?B?bmc2QWwwYzlwbUpPSFZiUXpwRGYyYVYweEx1SEgyNnVNVS9qUTMvRUpvZlZP?=
 =?utf-8?B?dC9ISGR5V05NczRvc3pMYnNiZlhxeXZxZGV1VU1BMWhDMGhIQmVzUXc1L0h3?=
 =?utf-8?B?b01ZS0VNVUJKclZHa1kvN0VnMEVjSXVBbVlaN01kSzhtdE5GV2FHZU5vTWdt?=
 =?utf-8?B?RXdKeFJSWnRFWXQrTkQ3enJML0RLVFNZZ1YzMnBNTDZTT0xrcWUrN0JwOHRQ?=
 =?utf-8?B?TVBYMEVEUzdsb2hud1BCM2lFVVBlYm5hZHdpdUoxZDk4VVB1eE5uYm5CdmNF?=
 =?utf-8?B?M2ZUYWgrTForVjFIanNySVRNQjVaYTFEcXA1aU5ILzNWaEZCTTBwV2ZxQVhS?=
 =?utf-8?B?amFJdEN3U0JyQjBUOW9SMENQT29YbmxMVmdtc0VFZDBUenhhd1UrSkw2Z08z?=
 =?utf-8?B?cEJKcU9tTkN4Z1IyaDF0WDh5OGlQNitQVUU0N1N1T3MzbGtWM2pwdGpSTDcz?=
 =?utf-8?B?UDRLdzlxMXlIamNEdGVpOVZFbUVSTVE0Y3hXcWRFbkdhODl2cGhWRnNXWnlX?=
 =?utf-8?B?QkI0b1Z5WFJGUm02MWdFWVpFK1hERjFVMVdqVWdIUUhEMnFXNHhMQkdvQkNl?=
 =?utf-8?B?aERKcEJsYVA0ZFVQMDJDVUx3NWF1Y3dURE1RWTdNdlZnTnFydnRnT29NeXFy?=
 =?utf-8?B?c2w5QmJsK25mWGpDcDhXL21uREhMa0xlanZGUjhwNFFlcFVCTWpxR2RkKzhO?=
 =?utf-8?B?cFNybDJzSlZrNlVxQWE4ak5Yb0xWMlg5alVJUy95VTM2ck1RZWM2UmZoVlMr?=
 =?utf-8?B?T0RPM3ArSUh6OG9xbEo2MkRmZkpJWGJSaXZDRWN4Y1VXdDB0YmlyQmtwejBJ?=
 =?utf-8?B?dUhwYkIvTWo2R2V4UWt6NmR4cEtuWDNxUVJTV0FrdmpPT0tvSTZGWS9NRk12?=
 =?utf-8?B?ZFova1lmVmJJSm5lZCs3NnE4ZjVKQWdhQnluU1BicUc3M2xndnQzaVRkSXFr?=
 =?utf-8?B?U1o5elpyYTRxczNKQzdxWk10NnZOUUpBaEI1ZVArSmlBdkJqYTRnNTdCU2hy?=
 =?utf-8?B?ckdQOWVFTGVqM0lpYkdYaDd5akFKSnFNNGpuczJ2K0EvK2xGWkFCKzZ3a3BR?=
 =?utf-8?B?U2tSTEdNUXV4N2Q0QUpmbGcyUU9UUVlDQWxIQTI0ZEg2ZWt6dDRNZTdBbnRI?=
 =?utf-8?B?ZWl5dk5LeUtMakU5aHpGQU1RWlM5RVEwSStMSDBYTDlDbFoyQy9CVzNqOUdx?=
 =?utf-8?B?ZnVFcjR3YVJBcDhWVDViTVcyaUJrNFhNRDhHdDd4MncxQVIwK1kzdjBEMVZa?=
 =?utf-8?B?V24xbTQvSUNrMDRzMWUwblUvNENXUEh3SUR2Szk4dWNqdkRHZ0RNRTZ2MVcw?=
 =?utf-8?Q?SkVqT2wj1P1EUNMxKVpKigTLsq+lUCL7AZVEsCa?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c36a49e-b0ba-4919-c747-08d9878bff95
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 23:09:21.0825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yqy0TMb7cuISE0gW+Dvb7OH1d09z/p4gR8pTThMJRdeqnKjnWtyYMHmLijxIfzfutJKWVwxhTCIdIvyzz9Ctkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3961
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/4/21 7:04 PM, Russell King (Oracle) wrote:
> On Mon, Oct 04, 2021 at 03:15:19PM -0400, Sean Anderson wrote:
>> As the number of interfaces grows, the number of if statements grows
>> ever more unweildy. Clean everything up a bit by using a switch
>> statement. No functional change intended.
> 
> This doesn't look right to me.
> 
>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>> index e2730b3e1a57..18afa544b623 100644
>> --- a/drivers/net/ethernet/cadence/macb_main.c
>> +++ b/drivers/net/ethernet/cadence/macb_main.c
>> @@ -510,32 +510,55 @@ static void macb_validate(struct phylink_config *config,
>>  			  unsigned long *supported,
>>  			  struct phylink_link_state *state)
>>  {
>> +	bool one = state->interface == PHY_INTERFACE_MODE_NA;
> 
> Shouldn't this be != ?
> 
> Since PHY_INTERFACE_MODE_NA is supposed to return all capabilities.
> 

Ah, yes it should.

--Sean