Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 04 Oct 2021 20:44:47 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     Kim Phillips <kim.phillips@amd.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Stephane Eranian <eranian@google.com>
CC:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        acme@redhat.com, jolsa@redhat.com, namhyung@kernel.org,
        irogers@google.com
Subject: Re: [PATCH v1 11/13] perf tools: improve IBS error handling
User-Agent: K-9 Mail for Android
In-Reply-To: <aa40b532-0e95-76c0-6c9c-a91d45bf3468@amd.com>
References: <20210909075700.4025355-1-eranian@google.com> <20210909075700.4025355-12-eranian@google.com> <YT+nwP3jrzgxEdmu@kernel.org> <aa40b532-0e95-76c0-6c9c-a91d45bf3468@amd.com>
Message-ID: <25C12FFF-3F86-4733-B778-6C01A3138C25@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On October 4, 2021 6:57:09 PM GMT-03:00, Kim Phillips <kim=2Ephillips@amd=
=2Ecom> wrote:
>On 9/13/21 2:34 PM, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Sep 09, 2021 at 12:56:58AM -0700, Stephane Eranian escreveu:
>>> From: Kim Phillips <kim=2Ephillips@amd=2Ecom>
>>> +static void detect_amd(void)
>>> +{
>>> +	FILE *inf =3D fopen("/proc/cpuinfo", "r");
>>> +	char *res;
>>> +
>>> +	if (!inf)
>>> +		return;
>>> +
>>> +	res =3D fgrep(inf, "vendor_id");
>>> +
>>> +	if (res) {
>>> +		char *s =3D strchr(res, ':');
>>> +
>>> +		is_amd =3D s && !strcmp(s, ": AuthenticAMD\n");
>>> +		free(res);
>>> +	}
>>> +	fclose(inf);
>>> +}
>>> +
>>=20
>> We have perf_env for such details, for instance in
>> tools/perf/util/sample-raw=2Ec we have:o
>>=20
>>          const char *arch_pf =3D perf_env__arch(evlist->env);
>>          const char *cpuid =3D perf_env__cpuid(evlist->env);
>>=20
>> 	        else if (arch_pf && !strcmp("x86", arch_pf) &&
>>                   cpuid && strstarts(cpuid, "AuthenticAMD") &&
>>                   evlist__has_amd_ibs(evlist)) {
>
>OK, I've rebased this 11/13 patch onto the new perf_env__{arch,cpuid}=20
>code, and posted it here:
>
>https://lore=2Ekernel=2Eorg/lkml/20211004214114=2E188477-1-kim=2Ephillips=
@amd=2Ecom/T/#mc4c9c582e3816ab31af6d0187e6803de1a98ac84
>
>The following 12/13 patch in this series changes, too, but since it=20
>depends on prior patches in the series, I'll reply-all to 12/13 with its=
=20
>new version=2E
>
>Arnaldo, would it be ok to apply the two new patches that replace this=20
>11/13?  They don't depend on any others in this series, and it would=20
>save Stephane from having to carry them=2E


I'll work in this tomorrow, thanks

- Arnaldo
>
>Thanks,
>
>Kim