Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC net-next PATCH 09/16] net: macb: Move most of mac_prepare to
 mac_config
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>
References: <20211004191527.1610759-1-sean.anderson@seco.com>
 <20211004191527.1610759-10-sean.anderson@seco.com>
 <YVuIvHZ6+AHvGPoe@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <2b87ce05-4c10-3644-0df8-fc7b47d74e50@seco.com>
Date:   Mon, 4 Oct 2021 19:09:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YVuIvHZ6+AHvGPoe@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEFQMW02Qm5mSU9kaEwycm1MbEdEa3RNUGJSYVBsd1VJNXRWYXBRYzRxMy9H?=
 =?utf-8?B?VnNsSmRSZTJYQS9tOE5BZ0g0bWNSWXJkcENybG1maDNzb2s2a0ZJL3NLZk83?=
 =?utf-8?B?SWVnTEpydU44eTMybTFrL2xla0lyOTFRODBFVllabmpPemZSUzN0b0dYNHF6?=
 =?utf-8?B?VUM0bDNmY3VodTlrNFQzbVBTUEJTd24wc0hiS0xYdmIzV3VORzZTSlVMajFq?=
 =?utf-8?B?RFE2eGRoZ0JaVnRQYVJXSDdlcHYxMTNoWks0eGtpMCtxcVVvcW41eVRCZmpF?=
 =?utf-8?B?cG9kcnlSbG50Y2hsVFo1YWhIOS9vQ040dWxJR3NTZTFnWTJtYU1mU09YQ0U5?=
 =?utf-8?B?bFNXM3ZmUEJoUGdlS2kvTGVvQUExdHdTK1RmYnlEL1JnOCs3emlhYlVtTlFM?=
 =?utf-8?B?bTdrTCtWamI2TzRiSzY5OWNNcVdYc1U1bU9neWM5bEpDNHNObGcvUGVDSFU4?=
 =?utf-8?B?MnQ3M1liS2pWNnphNG9zR3REbFlIR1EySS9ZNGJwTitvYWJxQkJmbGk5OFRy?=
 =?utf-8?B?SEM5MzZrODJGdmwzNjBMYUFmZ1NIRWdBSjVCR3NzbFQ5bnh3NDY0enQ5N1Av?=
 =?utf-8?B?VjNWQy9GZUsxUDdiRisyTUlaWG1FSzRYTXNuaGhhYzZienFienNrYUdDTERy?=
 =?utf-8?B?M0Y5QlQyMXpiVEZqckI5cC9uaWZxVWk5NG1VWFVyZHVVanBCTmJLWkJ2RnBJ?=
 =?utf-8?B?cWk3Q1dDYTdtWGZrcFBNNmNjczd6a3QvTURrUXhuSlpFOEpERWRXU1pMb09R?=
 =?utf-8?B?NUloTDU0bHFkSnE0WTdMcWZxemQ4ZG85VzNxUEJ4cDN0YjhtN3A0TXc3M1NH?=
 =?utf-8?B?azFucjNOMm1JVEtFUTZUNEpWdG5ac2REOXZYNWlXV2pNTWk2cGZtZU9WRGhD?=
 =?utf-8?B?TDFJNDN1K1Q3ekhXbUdXT05KVU1FNkpxWWFsY05OcW5kTmJ2K3pCc2U1OGNZ?=
 =?utf-8?B?U1lTYWJTcUdMODVSQzF6Wmd6dnRDR29VNi84V3lXUi96RXFDQXBkTFEwblVk?=
 =?utf-8?B?a0RwU0ZqTW5kaHBDdTF2d3UxbkpweHpzc3VPbFlCQlJGbExsM3JZdVRCcTJY?=
 =?utf-8?B?aG5WRHlObmt6Ky9lSWJsNVBjQnJiR244aDl4cjJPQnJyRllSeEtYeHZMN00r?=
 =?utf-8?B?UVJsZVJ0RElWbHRFeUpKaTVlVjM1NEN2dUZVTXdDa2t3UFZEcG1vUWxQVCtn?=
 =?utf-8?B?UldWUy9rRVB1RFZEMWQ0TXI3dlNDN0JlZ1NaaURFaXkzTmNjYlBjVlA3bkxx?=
 =?utf-8?B?UC8rcTBmTDYwMzB2QURkZU9pMmNZanYxMlpQUVE4bUl0eUZvMFU1aTl5d0pv?=
 =?utf-8?B?eXBkc2pDRTRDK2VrbGFNMUNIZXZhcmxkcnZOcDVZTFVEZW8rV25MWFBrRWhz?=
 =?utf-8?B?NkFVUGUyMVhpZFlkVTQ0UFdvM29VQmx6dlZBbGNKczlLL29IeGk5YXVLQ2w1?=
 =?utf-8?B?STFWQWZjOVBjZjgxUXNlMHVSazBBcDJOZmZTS25yekkvRWRFT1U5QzNvL0NM?=
 =?utf-8?B?MFNpVnl3Z245NW5RODNySVFJaW56NnRwamhSOHREb0xaeFcya3NkTlkzZjZr?=
 =?utf-8?B?djFLaTIvSnBjcXZ2bGhrQXF4M1lRVHdTR1p3MkRwU3VETEd1dWpOQnQwUmtF?=
 =?utf-8?B?b3g1TlRZRUtXSWRDNGdzN0h5ZmlSOGxTSjF2eEVWUTRzVzFVQi9YaXBRVzlU?=
 =?utf-8?B?TldleGZTaTBBRkhndDVQalhkUCtYcDY1U0dJMWk0YzRUTVBRa1hYRDJYYWpi?=
 =?utf-8?Q?EPvs3yRTqhzQHxeur3iyiv5QAuCMvt7dxNbg2yX?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 814d4df7-89d5-4ffa-c6c0-08d9878c143c
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 23:09:55.5162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7YnbIQf04B5IhMpy+sg2ajEKJPNqQfgj7S7O8tAlzbBm3j8gJThrmq4rijfw83vE8ShTnGeB+yncGB5onkf+Bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB3046
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/4/21 7:05 PM, Russell King (Oracle) wrote:
> On Mon, Oct 04, 2021 at 03:15:20PM -0400, Sean Anderson wrote:
>> mac_prepare is called every time the interface is changed, so we can do
>> all of our configuration there, instead of in mac_config. This will be
>> useful for the next patch where we will set the PCS bit based on whether
>> we are using our internal PCS. No functional change intended.
> 
> The subject line appears to be the reverse of what you're actually
> doing.
> 

So it does.

--Sean