Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 4 Oct 2021 12:54:07 -0500
From:   Rob Herring <robh@kernel.org>
To:     Nishanth Menon <nm@ti.com>
Cc:     Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, Suman Anna <s-anna@ti.com>,
        Sinthu Raja <sinthu.raja@ti.com>,
        Hari Nagalla <hnagalla@ti.com>,
        Sinthu Raja <sinthu.raja@mistralsolutions.com>,
        Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC
 only compatibles
Message-ID: <YVs/v7g8wwLq/ujb@robh.at.kernel.org>
References: <20210925201430.11678-1-nm@ti.com>
 <20210925201430.11678-3-nm@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210925201430.11678-3-nm@ti.com>
Precedence: bulk

On Sat, Sep 25, 2021 at 03:14:28PM -0500, Nishanth Menon wrote:
> Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> just state SoC compatibles without specific board specific compatibles
> aligned with what we have done for J721E/J7200 platforms as well.

This is the wrong direction IMO. Why do you want this other than 
alignment?

> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Motivation to introduce in V2:
> * Retain consistency with both "soc only" and "board specific" as two
>   schemes we support across k3.
> 
> V1:  did'nt exist
> 
>  .../devicetree/bindings/arm/ti/k3.yaml        | 23 +++++++++++--------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index cefb06424a4a..30c3f5c70014 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -20,12 +20,15 @@ properties:
>      oneOf:
>  
>        - description: K3 AM654 SoC
> -        items:
> -          - enum:
> -              - ti,am654-evm
> -              - siemens,iot2050-basic
> -              - siemens,iot2050-advanced
> +        oneOf:
>            - const: ti,am654
> +          - items:
> +              - enum:
> +                  - ti,am654-evm
> +                  - siemens,iot2050-basic
> +                  - siemens,iot2050-advanced
> +              - const: ti,am654
> +
>  
>        - description: K3 J721E SoC
>          oneOf:
> @@ -44,11 +47,13 @@ properties:
>                - const: ti,j7200
>  
>        - description: K3 AM642 SoC
> -        items:
> -          - enum:
> -              - ti,am642-evm
> -              - ti,am642-sk
> +        oneOf:
>            - const: ti,am642
> +          - items:
> +              - enum:
> +                  - ti,am642-evm
> +                  - ti,am642-sk
> +              - const: ti,am642
>  
>  additionalProperties: true
>  
> -- 
> 2.32.0
> 
>