Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4184277pxb; Mon, 4 Oct 2021 19:54:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLg4pM74FxeY96Ir4oc0epv6c0fRHUBe/3naR0iWqkwVR8wu/RQY+sLSovH0t+kaqOjykd X-Received: by 2002:a05:6402:546:: with SMTP id i6mr4770854edx.321.1633402448737; Mon, 04 Oct 2021 19:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633402448; cv=none; d=google.com; s=arc-20160816; b=krWrmTRtWktUrBI45G9/KtMIorLwFo3+Uvgg8k9aKGTlvkNULbKWsXCkrcgneWmmpB /U+zkOfKVgGxd2YU27tfrUWijd5837GXnyIPTayQYZEQszIa+JyNZqJvlPU1jHwBCFCr HC3NAjGVKUgJdlXMWXtzTERuK3LuH6NWz3fKq5d0c8xThjjXJuwCB4MW1MS7UQpkS5HY QRLFhjpvVjz6D1A2v1fJ9xEyxoxx7q3kR/sLkvl69tsBJAJbvepYluFDAFNW8QtfCL/A +RrCp8+eLzHNfcuNpboRe8UvUk25clJadnyRIJ/l2tzv7fLKwDOyE0b9aJIGkPyr+MNN ELGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3T0p9idjYhu8M/ef45mevJxBks6cFZOGq74RxRztP7Y=; b=jXsAdFF6Cklea8LwaD6O9ROGTfvIrRn+EHAXlBdjnZ7wh4F6LoGKYlOhcIHiA43Cpp pNC3M2+X760eRM2fzB2tcc5viHhSe+gjDOPqL4p1NLF+3qlwh94OfJaonWEwwSkB11og z3+REYBNg4hdOSfb6oGiSLYiJPMxFjcUESXjHsZPIDIBwYV7dIr7AntGshQxsgrI63su ici0E2QsjLnmSSWh2NvfU6VYv/ER64r/l0lVFTKlFcMLzEQaCp5DD5xRzgozjr2SVPta 2ks3sEl0+EtK+Jn6UHZs1qI3yrCS9WmphHDUs2JdrMaPfda+bBMgVuBJisYyX+l3h4G1 mWsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si13329599edx.412.2021.10.04.19.53.45; Mon, 04 Oct 2021 19:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbhJECyQ (ORCPT + 99 others); Mon, 4 Oct 2021 22:54:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:43302 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbhJECyO (ORCPT ); Mon, 4 Oct 2021 22:54:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="248894616" X-IronPort-AV: E=Sophos;i="5.85,347,1624345200"; d="scan'208";a="248894616" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 19:52:25 -0700 X-IronPort-AV: E=Sophos;i="5.85,347,1624345200"; d="scan'208";a="483409086" Received: from asaini1-mobl1.amr.corp.intel.com (HELO skuppusw-desk1.amr.corp.intel.com) ([10.251.138.96]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 19:52:24 -0700 From: Kuppuswamy Sathyanarayanan To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Josh Poimboeuf , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel Cc: Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org Subject: [PATCH v8 01/11] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT Date: Mon, 4 Oct 2021 19:51:55 -0700 Message-Id: <20211005025205.1784480-2-sathyanarayanan.kuppuswamy@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> References: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Kirill A. Shutemov" CONFIG_PARAVIRT_XXL is mainly defined/used by XEN PV guests. For other VM guest types, features supported under CONFIG_PARAVIRT are self sufficient. CONFIG_PARAVIRT mainly provides support for TLB flush operations and time related operations. For TDX guest as well, paravirt calls under CONFIG_PARVIRT meets most of its requirement except the need of HLT and SAFE_HLT paravirt calls, which is currently defined under COFNIG_PARAVIRT_XXL. Since enabling CONFIG_PARAVIRT_XXL is too bloated for TDX guest like platforms, move HLT and SAFE_HLT paravirt calls under CONFIG_PARAVIRT. Moving HLT and SAFE_HLT paravirt calls are not fatal and should not break any functionality for current users of CONFIG_PARAVIRT. Co-developed-by: Kuppuswamy Sathyanarayanan Signed-off-by: Kuppuswamy Sathyanarayanan Signed-off-by: Kirill A. Shutemov Reviewed-by: Andi Kleen Reviewed-by: Tony Luck --- Changes since v7: * None. arch/x86/include/asm/irqflags.h | 46 ++++++++++++++++----------- arch/x86/include/asm/paravirt.h | 20 ++++++------ arch/x86/include/asm/paravirt_types.h | 3 +- arch/x86/kernel/paravirt.c | 3 +- 4 files changed, 41 insertions(+), 31 deletions(-) diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index c5ce9845c999..2a2ebf9af43e 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -59,27 +59,15 @@ static inline __cpuidle void native_halt(void) #endif -#ifdef CONFIG_PARAVIRT_XXL -#include -#else -#ifndef __ASSEMBLY__ -#include +#ifdef CONFIG_PARAVIRT -static __always_inline unsigned long arch_local_save_flags(void) -{ - return native_save_fl(); -} - -static __always_inline void arch_local_irq_disable(void) -{ - native_irq_disable(); -} +# ifndef __ASSEMBLY__ +# include +# endif /* __ASSEMBLY__ */ -static __always_inline void arch_local_irq_enable(void) -{ - native_irq_enable(); -} +#else /* ! CONFIG_PARAVIRT */ +# ifndef __ASSEMBLY__ /* * Used in the idle loop; sti takes one instruction cycle * to complete: @@ -97,6 +85,28 @@ static inline __cpuidle void halt(void) { native_halt(); } +# endif /* __ASSEMBLY__ */ + +#endif /* CONFIG_PARAVIRT */ + +#ifndef CONFIG_PARAVIRT_XXL +#ifndef __ASSEMBLY__ +#include + +static __always_inline unsigned long arch_local_save_flags(void) +{ + return native_save_fl(); +} + +static __always_inline void arch_local_irq_disable(void) +{ + native_irq_disable(); +} + +static __always_inline void arch_local_irq_enable(void) +{ + native_irq_enable(); +} /* * For spinlocks, etc: diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index da3a1ac82be5..d323a626c7a8 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -97,6 +97,16 @@ static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) PVOP_VCALL1(mmu.exit_mmap, mm); } +static inline void arch_safe_halt(void) +{ + PVOP_VCALL0(irq.safe_halt); +} + +static inline void halt(void) +{ + PVOP_VCALL0(irq.halt); +} + #ifdef CONFIG_PARAVIRT_XXL static inline void load_sp0(unsigned long sp0) { @@ -162,16 +172,6 @@ static inline void __write_cr4(unsigned long x) PVOP_VCALL1(cpu.write_cr4, x); } -static inline void arch_safe_halt(void) -{ - PVOP_VCALL0(irq.safe_halt); -} - -static inline void halt(void) -{ - PVOP_VCALL0(irq.halt); -} - static inline void wbinvd(void) { PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index d9d6b0203ec4..40082847f314 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -150,10 +150,9 @@ struct pv_irq_ops { struct paravirt_callee_save save_fl; struct paravirt_callee_save irq_disable; struct paravirt_callee_save irq_enable; - +#endif void (*safe_halt)(void); void (*halt)(void); -#endif } __no_randomize_layout; struct pv_mmu_ops { diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 04cafc057bed..8cea6e75ba29 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -283,9 +283,10 @@ struct paravirt_patch_template pv_ops = { .irq.save_fl = __PV_IS_CALLEE_SAVE(native_save_fl), .irq.irq_disable = __PV_IS_CALLEE_SAVE(native_irq_disable), .irq.irq_enable = __PV_IS_CALLEE_SAVE(native_irq_enable), +#endif /* CONFIG_PARAVIRT_XXL */ + .irq.safe_halt = native_safe_halt, .irq.halt = native_halt, -#endif /* CONFIG_PARAVIRT_XXL */ /* Mmu ops. */ .mmu.flush_tlb_user = native_flush_tlb_local, -- 2.25.1