Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Len Baker <len.baker@gmx.com>, Hannes Reinecke <hare@suse.com>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-hardening@vger.kernel.org, Kees Cook <keescook@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded arithmetic
Date:   Tue,  5 Oct 2021 00:34:38 -0400
Message-Id: <163340840528.12126.5824818012998288019.b4-ty@oracle.com>
In-Reply-To: <20210925114205.11377-1-len.baker@gmx.com>
References: <20210925114205.11377-1-len.baker@gmx.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3ZFM3dwRmpVcUtqeHR0UlUxa3dUWEE2TmQyaHBSZGRNZWhnL1kxaVhweVd6?=
 =?utf-8?B?Z29hdUFjRSs0R1pPaXNPZXYxT09BLzU1Vi9TN1cvRTZ2UC9tcm50UGx0S25z?=
 =?utf-8?B?cDFUWmQ4aWR3SWJ6Y29zSTlLV3JZbVNaVkh6M21FbmtLaEhtWG4xS24xSE5N?=
 =?utf-8?B?N2RET2N6cm82QlV6WmxZbHlibklZNE1ZdEF3cklzanMvV3J4dWV4dEYxY1h5?=
 =?utf-8?B?RkVIQm9yNTVVeG9KS0dtbG1KeFEwMENvYVl5RDI0L3poUWw0WEJGajJIdnBS?=
 =?utf-8?B?UG9uSjNaSEhPOE9vMEd6QzhrT0R5MlNPQTQ0NXEyZ0hZTkdlUlZralh2b0Y0?=
 =?utf-8?B?Qnk4S2svZnhTcERqZUtteVppbHJWa1pOa21mSFMyeUZhbk1zR1ZVLzhtKzZY?=
 =?utf-8?B?eWhTY09pUVU5bWVPdDE4S0kydVN3ZEtOaWZuOE5nZGhmQTR3S0VxNStNeEh0?=
 =?utf-8?B?QjdKZElHRFJRUHJ1QmNrZEc5eE44c3hEM1FpMzQ2ZjZOZ2pCMnowWUpCTVc2?=
 =?utf-8?B?dXZVMjJtR3NSNzVqazMvelpOTFBDczV6NjZwR2YzY0xMNkFYdGlCeklRUzcr?=
 =?utf-8?B?aTRGZE40d3NZZnVKUXQwV01lbWM2UmRRNTRwK2UvelRXa2EyeHB6enZ6UXda?=
 =?utf-8?B?amdocTJ1aHc0a21kNjlYOVYwdWhUeFZXaElDZzZJQjJoTTNXeDQrNXB4Uzlp?=
 =?utf-8?B?M3prejdQT0hxdlc1T0syeGk5eUNCL0w1RkRETjBJZERrNGRZZmUzdkZRLy9Q?=
 =?utf-8?B?TUhUUjZYUmlibXN2MVpYQmdSaExyU2QrM2lyUzlDWlBnSDRMUHZmckNLdlJ6?=
 =?utf-8?B?NlNJa29Fc2t5eWdoQzZnZXM5QVNIWERmWWNHQzQ2dUZUb2RVVUtxem95Ynor?=
 =?utf-8?B?bFlJejVCTzhUSklnRHZaWmVqbXpJUjYwc3IxalIvZjdud0RLME55RUR5ZTVZ?=
 =?utf-8?B?QklJd2xHRDNtSktoZjVjYS96SVZGNm9YWDk0TTVlYVROQlVmTlZUQW5TVDJ6?=
 =?utf-8?B?WU9YaFR4V1g0ZmNkRkRZWWN0N0RLQlpKRHZsMXhpRFdoMzVBSHlqaFV1dHJM?=
 =?utf-8?B?V1g5TzNkeXRadG1FYWkyb1VuRytZTncyeU96dEtvYkV3d1NGdUZtVG1yTUcy?=
 =?utf-8?B?dUNqZE40dzBSVE1QWW1hUllZUlBxdm1PSkpJUG5FKzlsNXNHamgvOWMzemZ2?=
 =?utf-8?B?aEFKLzZ2VXM4Ukd4ajlZVjdIbEtiVERaL0JkN2FKeWxqZjFFZjFxWnVHUE9U?=
 =?utf-8?B?aU5lWXBFZ0VGQWtXL2FPdk0vZGhLSzBoME1FTVRsako0cW9jQVJhRG5oZGg1?=
 =?utf-8?B?MVpwOW5DZDhSSmNLVk9vUDdaVHcxYW40bTZVYmtJcW1KS0VDWnluTXdyaWtn?=
 =?utf-8?B?OGNnbEM3SEhxc2twanpKcHlRSXZ4M3FOaDRLQlNyMm54K3lJN21MYzMzMjlS?=
 =?utf-8?B?S2RBeUJ0OC9yVy9RWVN5ZWQ1ZkhXaGVNUVdqUmFMdEY3a1FJNW1UTFJHeGtP?=
 =?utf-8?B?RG53Z3FoZ2dnRHZtRVJoaE9pZGxneTFxZHlOb1NFbDBjaVA1VEFuR0VJbWV2?=
 =?utf-8?B?eXVxU0JwSE90UVpid1YxMnAySjlmWEhrY09OUWNoVlVkdmZCUml1TTNTNzRn?=
 =?utf-8?B?UjhXV0xXelFubUZZSDU1OVhWVk9EZkJiemtiZTg1RXdZWmJvMnpxbkVlenZC?=
 =?utf-8?B?QVAzNjdiWkRvcDM4U0hIZTlodGQ4ZFgvSW9xMld3a1RYMHNmQVhDNUNjVTFY?=
 =?utf-8?Q?apaX63YsrxE7k1ilHKSXFAW0JlyL8oIRs5uEI4G?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b2518ce-b60a-494b-bdf3-08d987b97c0c
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4754.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 04:34:57.2093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bDQ09lga+VOAHaVnNvd+txMf7T0//jPofP9bIEiFC5Ce3lDOUM/8CJ7j8wRhC/sNHJ6v7tP/RSBd4/IDBk+30tNjywompmTu40P06M/8JII=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1950
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10127 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 phishscore=0
 spamscore=0 mlxscore=0 mlxlogscore=865 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110050025
X-Proofpoint-GUID: kCu6UeHI-Hf1xUQ5Ok3sg1PtTnu1hOo8
X-Proofpoint-ORIG-GUID: kCu6UeHI-Hf1xUQ5Ok3sg1PtTnu1hOo8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 25 Sep 2021 13:42:05 +0200, Len Baker wrote:

> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: advansys: Prefer struct_size over open coded arithmetic
      https://git.kernel.org/mkp/scsi/c/568778f5572a

-- 
Martin K. Petersen	Oracle Linux Engineering