Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964953AbWLTJdy (ORCPT ); Wed, 20 Dec 2006 04:33:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964956AbWLTJdy (ORCPT ); Wed, 20 Dec 2006 04:33:54 -0500 Received: from amsfep20-int.chello.nl ([62.179.120.15]:36469 "EHLO amsfep20-int.chello.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964953AbWLTJdx (ORCPT ); Wed, 20 Dec 2006 04:33:53 -0500 Subject: Re: 2.6.19 file content corruption on ext3 From: Peter Zijlstra To: Linus Torvalds Cc: Andrei Popa , Andrew Morton , Linux Kernel Mailing List , Hugh Dickins , Florian Weimer , Marc Haber , Martin Michlmayr In-Reply-To: References: <1166314399.7018.6.camel@localhost> <20061217040620.91dac272.akpm@osdl.org> <1166362772.8593.2.camel@localhost> <20061217154026.219b294f.akpm@osdl.org> <1166460945.10372.84.camel@twins> <1166466272.10372.96.camel@twins> <1166468651.6983.6.camel@localhost> <1166471069.6940.4.camel@localhost> <1166571749.10372.178.camel@twins> Content-Type: text/plain Date: Wed, 20 Dec 2006 10:32:32 +0100 Message-Id: <1166607152.10372.199.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 34 On Tue, 2006-12-19 at 16:23 -0800, Linus Torvalds wrote: > Pls test. Is good. Only s390 remains a question. Another point, change_protection() also does a cache flush, should we too? > ---- > diff --git a/mm/rmap.c b/mm/rmap.c > index d8a842a..eec8706 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -448,9 +448,10 @@ static int page_mkclean_one(struct page *page, struct vm_area_struct *vma) > goto unlock; > > entry = ptep_get_and_clear(mm, address, pte); flush_cache_page(vma, address, pte_pfn(entry)); > + flush_tlb_page(vma, address); > entry = pte_mkclean(entry); > entry = pte_wrprotect(entry); > - ptep_establish(vma, address, pte, entry); > + set_pte_at(mm, address, pte, entry); > lazy_mmu_prot_update(entry); > ret = 1; > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/