Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v8 0/4] Add Nvidia Tegra GPC-DMA driver
To:     Akhil R <akhilrajeev@nvidia.com>
CC:     <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
        <kyarlagadda@nvidia.com>, <ldewangan@nvidia.com>,
        <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <p.zabel@pengutronix.de>, <rgumasta@nvidia.com>,
        <thierry.reding@gmail.com>, <vkoul@kernel.org>
References: <1632759090-7965-1-git-send-email-akhilrajeev@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <6f45ee92-d0cb-92d5-a7db-3466af3e13d8@nvidia.com>
Date:   Tue, 5 Oct 2021 08:43:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <1632759090-7965-1-git-send-email-akhilrajeev@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 07:43:43.3247
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: df2db851-9d23-45ce-299a-08d987d3db2f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT035.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3803
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 27/09/2021 17:11, Akhil R wrote:
> Add support for Nvida Tegra general purpose DMA driver for
> Tegra186 and Tegra194 platform.
> 
> Changes in patch v8:
>    * Fixed dt_binding_check errors in binding doc .
>    * Updated get_burst_size and dma_tx_status functions.
>    * Removed slave_id assigning in tegra_dma_slave_config
>    * dt node name changed from dma to dma-controller
> 
> v6..v7 - https://lkml.org/lkml/2021/9/17/652
> v2..v5 - https://lkml.org/lkml/2021/9/16/455
> v1 - https://lkml.org/lkml/2020/7/20/96
> 
> Akhil R (4):
>    dt-bindings: dmaengine: Add doc for tegra gpcdma
>    dmaengine: tegra: Add tegra gpcdma driver
>    arm64: defconfig: tegra: Enable GPCDMA
>    arm64: tegra: Add GPCDMA node for tegra186 and tegra194
> 
>   .../bindings/dma/nvidia,tegra186-gpc-dma.yaml      |  108 ++
>   arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi     |    4 +
>   arch/arm64/boot/dts/nvidia/tegra186.dtsi           |   44 +
>   arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi     |    4 +
>   arch/arm64/boot/dts/nvidia/tegra194.dtsi           |   44 +
>   arch/arm64/configs/defconfig                       |    1 +
>   drivers/dma/Kconfig                                |   12 +
>   drivers/dma/Makefile                               |    1 +
>   drivers/dma/tegra186-gpc-dma.c                     | 1298 ++++++++++++++++++++
>   9 files changed, 1516 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
>   create mode 100644 drivers/dma/tegra186-gpc-dma.c


For the series ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

I have a couple minor comments, but otherwise it is fine.

Jon

-- 
nvpublic