Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211004141839.49079-1-andriy.shevchenko@linux.intel.com>
 <7019ca3e-f076-e65b-f207-c23a379ade29@gmail.com> <20211005085100.GB17524@pengutronix.de>
In-Reply-To: <20211005085100.GB17524@pengutronix.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 5 Oct 2021 12:17:32 +0300
Message-ID: <CAHp75Ve6cpNkF3BB7LQhaXdQcW5j6X8QVbPj9aQy2JLgDppBfw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to
 the right controller"
To:     Michael Grzeschik <mgr@pengutronix.de>
Cc:     Ferry Toth <fntoth@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        USB <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Felipe Balbi <balbi@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 5, 2021 at 11:52 AM Michael Grzeschik <mgr@pengutronix.de> wrote:
> On Mon, Oct 04, 2021 at 10:35:57PM +0200, Ferry Toth wrote:
> >Op 04-10-2021 om 16:18 schreef Andy Shevchenko:
> >>The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right
> >>controller") changed the device for the UDC and broke the user space scripts
> >>that instantiate the USB gadget(s) via ConfigFS.
> >
> >I confirm this regression on Intel Edison since at least 5.15-rc2
> >while in 5.14.0 it was working fine.
> >
> >This patch resolves the issue as tested on 5.15-rc4.
> >
> >Tested-by: Ferry Toth<fntoth@gmail.com>
>
> NACK! Why should we resolv an issue by reverting it to solve not working
> userspace.

Huh?!

It is
 a) used to work;
 b) stopped working after your commit.

To me it's a clear regression. Whatever deeper problem is there, I
really don't care. The change broke my _user space_ case!

> We already have this patch as a solution for solving a deeper
> Problem, regarding the allocator addressing the right device.

Then rework it. You have still time. Your case wasn't working and one
more release of not working is not an issue here.

> >>Revert it for now until the better solution will be proposed.
>
> So, I think fixing the userspace would be the right fix,

Huh?!
https://www.kernel.org/doc/html/latest/process/4.Coding.html#regressions

> not changing
> the kernel. Otherwise we should find a proper solution.

So, please do. v5.15 should still work on our devices with
distribution that uses ConfigFS, no?


-- 
With Best Regards,
Andy Shevchenko