Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4420727pxb; Tue, 5 Oct 2021 02:45:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+XWjyVA7XvWFJW8AfplGMGFCREC9UhJXAjp9eiU5wrrMQPa2QEzd07UrWGWOfaruleIKs X-Received: by 2002:aa7:9ac3:0:b0:440:4a66:50b5 with SMTP id x3-20020aa79ac3000000b004404a6650b5mr29471004pfp.73.1633427150706; Tue, 05 Oct 2021 02:45:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633427150; cv=none; d=google.com; s=arc-20160816; b=QV+uHkOCdSS/GWgeDxjhPBjcGAOQpfIiitaQEFIRKfXFVxNshhxxki7NdDOWkQmt50 IqB1qbqvlKu1QYFcXY1fmqtguO1m9eQrejdQsRtd+5SmNa9frGVwx7cv58KkMAXzr6RJ ZLjFa8Rtj3GMXapHfaHIQyoNXk38MlyABwUauqJYOJwU/YQyJvmhKx/1g2QCoXOnoUzZ za5ObOVXWDLOthoXwPEWqTA/WJcbRenLy1IRu/p1cjDqSn40hDpaxoUjoF0EfQw/l1uN xGhcCqqrgj4iWpfyhbEBlbY+d5uRfqmKg1PF8rwJQausm9bNje2LzsvDdB5NfXBdz5VK 0v/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=B+c0Yz3rhaln/4onGiQ0q8Ily+fWR2QQ7jO6q6FcE28=; b=DgjqV7lBnL30xqMIHcf5fwKnDcFwvt++UJ4K0NryoBfuqIuPic8TyzrzYBwIhYGqSd 4HhK1jdrykKKF46m3TKN+5/peje73FunKa1xOJe2t2I+WdSjP8z/A7gVPuJT6RG4HtQy bmcR8g4uh5SWAu65CQ64tK4EnwxdpRC9P4wOcc3uSQ2+iJK6UKZk5YrxiVvlS5zT3CFd XX4IjO9pK6a41kDnw1VXGJlXtyACO/ovasekDJVyzNFQTpDKsNi0TCBmt0AIKCzsb7rO Utd8kBnDMmlablNzJ6Htf+9X/9YEjnUNi/qULQu2MRMFpffXEyLI2OWlX7NUxqRYLKEM PM9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si3849736plc.37.2021.10.05.02.45.34; Tue, 05 Oct 2021 02:45:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233732AbhJEJqj (ORCPT + 99 others); Tue, 5 Oct 2021 05:46:39 -0400 Received: from alexa-out.qualcomm.com ([129.46.98.28]:17693 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233517AbhJEJqi (ORCPT ); Tue, 5 Oct 2021 05:46:38 -0400 Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 05 Oct 2021 02:44:48 -0700 X-QCInternal: smtphost Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/AES256-SHA; 05 Oct 2021 02:44:47 -0700 X-QCInternal: smtphost Received: from mkrishn-linux.qualcomm.com ([10.204.66.35]) by ironmsg01-blr.qualcomm.com with ESMTP; 05 Oct 2021 15:14:34 +0530 Received: by mkrishn-linux.qualcomm.com (Postfix, from userid 438394) id 2953A221DF; Tue, 5 Oct 2021 15:14:33 +0530 (IST) From: Krishna Manikandan To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krishna Manikandan , kalyan_t@codeaurora.org, robdclark@gmail.com, swboyd@chromium.org, bjorn.andersson@linaro.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH v1] drm/msm: use compatible string to find mdp node Date: Tue, 5 Oct 2021 15:14:31 +0530 Message-Id: <1633427071-19523-1-git-send-email-mkrishn@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the current implementation, substring comparison using device node name is used to find mdp node during driver probe. Use compatible string instead of node name to get mdp node from the parent mdss node. Signed-off-by: Krishna Manikandan --- drivers/gpu/drm/msm/msm_drv.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 2e6fc18..50a23cf 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -1241,9 +1241,16 @@ static int add_components_mdp(struct device *mdp_dev, return 0; } -static int compare_name_mdp(struct device *dev, void *data) +static int find_mdp_node(struct device *dev, void *data) { - return (strstr(dev_name(dev), "mdp") != NULL); + return of_device_is_compatible(dev->of_node, "qcom,mdp4") || + of_device_is_compatible(dev->of_node, "qcom,mdp5") || + of_device_is_compatible(dev->of_node, "qcom,mdss_mdp") || + of_device_is_compatible(dev->of_node, "qcom,sdm845-dpu") || + of_device_is_compatible(dev->of_node, "qcom,sm8150-dpu") || + of_device_is_compatible(dev->of_node, "qcom,sm8250-dpu") || + of_device_is_compatible(dev->of_node, "qcom,sc7180-dpu") || + of_device_is_compatible(dev->of_node, "qcom,sc7280-dpu"); } static int add_display_components(struct platform_device *pdev, @@ -1268,7 +1275,7 @@ static int add_display_components(struct platform_device *pdev, return ret; } - mdp_dev = device_find_child(dev, NULL, compare_name_mdp); + mdp_dev = device_find_child(dev, NULL, find_mdp_node); if (!mdp_dev) { DRM_DEV_ERROR(dev, "failed to find MDSS MDP node\n"); of_platform_depopulate(dev); -- 2.7.4