Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH] workqueue: Introduce __show_worker_pool_state and
 __show_workqueue_state.
To:     Tejun Heo <tj@kernel.org>
Cc:     jiangshanlai@gmail.com, linux-kernel@vger.kernel.org
References: <20210928103106.391694-1-imran.f.khan@oracle.com>
 <YVsvAQ94ucYdGNVM@slm.duckdns.org>
From:   imran.f.khan@oracle.com
Message-ID: <447be1eb-87df-6941-1e5c-db79918dc77b@oracle.com>
Date:   Tue, 5 Oct 2021 20:55:47 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <YVsvAQ94ucYdGNVM@slm.duckdns.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFBYQjNUdTdJR244UVNwTG9CeEg5QVYwSDU1RzFwOHk2TDhBU2VTZmNBayth?=
 =?utf-8?B?MzVLTjRGeE1XQXdiZHdsUFhERGJUOEw2UEFKd2IxZGd2NVFITy9BZkN6SHlB?=
 =?utf-8?B?VVRqK0Fob1cvU2lJekVJaHROTi9nejNmWUY4U1VBNkdJNGVPT3JLWWhNWjdv?=
 =?utf-8?B?Zkh6VjBRYUFWcEROYVVHSGtyWXFVakhRcFBKbjFSeTh4T0hKOWdUR0h1R1or?=
 =?utf-8?B?MGI2cEhEMkRCMkMzM0RtUG9VcjY5UlpZN29NRWtxSWJZWnBmMUIyTEVSc3VL?=
 =?utf-8?B?cEpnN29Hb0pTZzA4OWRaMkRUODlSdjFTRmVSOEYxYVdUZXQ1ZmRINHp6M0Na?=
 =?utf-8?B?K1RTaHU2UHVVaU5TOGNhTGlZUnNrcmsxVHZrM3p2ZTFNR25UQVBqcDc5TVhG?=
 =?utf-8?B?TVFxeEVWb25JQ0ZQelBiOGNJMXRDK2ZEUmFzVTNyUGRoZVhPNFQ4dXhoR3Rk?=
 =?utf-8?B?YzYzZjAyUjVjRDhwYUtocjc3cStGYmVuQ3h3Smp3bFdQSTYvZXllclFENmRw?=
 =?utf-8?B?eWZwVi9wMnI4VHdxRjdWVVRxMHAxKzk4V2tSRmN5eVJQbGtXSVZoZzg1WEs3?=
 =?utf-8?B?Uk1ieGNzVWFSRVZud2xQK2JqN2RFVS8wVU10YVhsZGFTRTNWWEwxRUozZm9Q?=
 =?utf-8?B?c2ZYbWUvR1B2bW94YnEvZUI5WU83Q0lZblF1TlBEbDJUR1V3eXRwQmY4eTZw?=
 =?utf-8?B?STMwdXc1Q3RuUnlZSEcyc0llYWlWaDkvNnNjREgvVElRV2V4VzZ1QmFMeGRG?=
 =?utf-8?B?MzkwUTJCanQycElBZ1Y5alVEcFFaR3J3WnlXSnpobmNsWGpwUjR4STlxZy8w?=
 =?utf-8?B?Y2F3MmU0N1BsdCtveVdZRTB3OG9YYWxUQi95anY3V2RCKzFHV3Y4RVlPTXA2?=
 =?utf-8?B?MG1iZDFDUTl5VEZrcVVmaEJWeFpkT1BmeVgyYlVtQlZVRjVsS1RXcm9ZYXdi?=
 =?utf-8?B?VUxKSkwrZXlWRzdDTENibGdmT1Zwa2JHQUNmaG96T3EwQU5kRjZRRysyRkpW?=
 =?utf-8?B?OENPRzEvRUZDcS9mbHdmNHhnNFZMdDJwUXZFVHRmK2lSUzVwd2VBUDdZanVH?=
 =?utf-8?B?ME1pZWhRZDJ2ZHhWSWVjYmFSNDhwT1hEQlRuUHI5OS9QcDIwSTc1Q3dGSG1s?=
 =?utf-8?B?ejZzclg4alZ6ZURFM25YeExxU0pXdzZBcmZvUFF4V1pucUxBV1VhQmRaVEpE?=
 =?utf-8?B?a0FDV3dpUGI5Ujc3NU1PeXV3WDcxdVRRUUc2VklzcnI1YnZTYmJjYmVwMlVQ?=
 =?utf-8?B?TlhuaDBNaEsxMjI4SFJGQjdRM2ZDdTN4MWtWUTJUaHpyaUNNR3FMRHV5ZDNi?=
 =?utf-8?B?Nk1vWXdiWDY1dEpjOTdOZlFBMVZYQ2xzNXlyb1lNTzl1T29INzFjTzFWbWps?=
 =?utf-8?B?bEhxOE0rVENlWXJlODhnWllIRHB6ODQ2aUVpQVY0QzRUdjN6dm5hSnhtTm5I?=
 =?utf-8?B?NlYyeTY3eWFtM21MdEJ5cHJYeFRpUFRkeEswYXFQdWNKNmpUT2lvaUNDVU95?=
 =?utf-8?B?MzBNa1p6VjRNaXNzck5pOVlyM1FWMDNjUUVkV0t6enNKTWtjYTNSVkpibXBN?=
 =?utf-8?B?Y0ptVGxRZnQra3ZUTlp2QlROY2JRZTVKbmhVTFFJRW80WlZzSzVLTWdMTHZY?=
 =?utf-8?B?RzNCQTRGT0w1bSt2SmpDVXl0bk9xSXVHSUVZcndlQ1MydFVFd0Y3N0VpUHkr?=
 =?utf-8?B?RXowL1VVNm1sS1pZODI3S1l0UXNZTC9ReVdlTUhML1NoV2JDSTJSS1IvQUUz?=
 =?utf-8?Q?1nk1q0t8l27POgv2+aGeqTtEnyxhrtxfqJKxnb/?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6e29798-708c-457b-de49-08d987e653d1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 09:55:57.1422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gYK874Qiv9nlDP1jmDomWXWOJXvm+8sU3rKyO7YkwqBq2RoN4bysZrxmYYDtvUVH6tBjtaLbazEgxg+aAyxg3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1421
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10127 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110050057
X-Proofpoint-GUID: ps4g39rtV4pxGGXtZGQkXhiA9_wrlHUK
X-Proofpoint-ORIG-GUID: ps4g39rtV4pxGGXtZGQkXhiA9_wrlHUK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/10/21 3:42 am, Tejun Heo wrote:
> On Tue, Sep 28, 2021 at 08:31:06PM +1000, Imran Khan wrote:
>> Currently show_workqueue_state shows the state of all workqueues and of
>> all worker pools.
>> Divide it into more granular functions (__show_workqueue_state and
>> __show_worker_pool_state), that would show states of individual workqueues
>> and worker pools.
> 
> But why is this change good? Are you building something on top later?
> 

The main motive was to dump data pertaining to only that workqueue which 
is being destroyed in destroy_workqueue.

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index cfae0c8d5e2e..e191646dd3e4 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4447,7 +4447,7 @@ void destroy_workqueue(struct workqueue_struct *wq)
                         raw_spin_unlock_irq(&pwq->pool->lock);
                         mutex_unlock(&wq->mutex);
                         mutex_unlock(&wq_pool_mutex);
-                       show_workqueue_state();
+                       __show_workqueue_state(wq);
                         return;
                 }
                 raw_spin_unlock_irq(&pwq->pool->lock);

Please let me know if I am missing some information that may be helpful 
here and can be obtained only by dumping the states of other workqueues.

Then while going through the code, it seemed better to break 
show_workqueue_state into more granular entities which can be used later 
for cases such as one mentioned above.

Thanks for reviewing this.

  -- Imran


> Thanks.
>