Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4443252pxb; Tue, 5 Oct 2021 03:16:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtlZa2WTqVSMzvfbgGRqt1oZWp020KEk1nn6gojIJ6A6Id8PAjUd3/EJC3eG/LoUWPVTcM X-Received: by 2002:a17:906:5010:: with SMTP id s16mr23664556ejj.245.1633428997614; Tue, 05 Oct 2021 03:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633428997; cv=none; d=google.com; s=arc-20160816; b=oOLMImyqdv5syq/J0OBg5e40hQ1SUhWSeEjx/foBU7jnbxn0KyT4DKRvkmO++bbD2c EG6z7PiWL+IlItoA07VS308c/oorJv6XFdS6k6aA2dhakpYAWO7WmSqZU1KyV7Q38ra8 SZG83cGmItZJsQHKlO6hVnua0suPBeSfFqRCTfObLC8sCc1lnygYj6owi1Jz5oXAxT02 S0YHLfHElYv2tuitBbH2tf8j3OvFF428DRd9x8wgDgWnX+kxJHMJbzaN0syPJPE8U9kC XluW3kx/T4i8J8iOR7/JjP9G1qmYzQhG5nE+8e1Fx0kHRQCh9e7xFmFb3eiAvNR4e+zo eppA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=UBZLxMuMMqAMN+6dt2Y8ZmEZCnKumRdcBRucu92Bimk=; b=qpw5kvaZB0umewcQvSjiv5iUAX5lPXJ7ftr5b3lMo1Y7E05dvmT34ReJFWaF/vWRXl BfQaRiGkH0c7Lj3SAIDB5tfKAcGOAT1N9nUm/K6UxAsN73cKnAk4nWW2M1CutzneiKD/ ROdaQ7Wbp6tSM7WqIzf8MA4fT82Ytg5ukdkEAua10p1O6v6IF1TF01nTNKNerGmlW6dQ Ew38GG1OyDI4i04Q1cs+sLlj8915Jnk5Z01736s8fwGMHoXTI9iCwPkAUNGcu6Jdvu66 LXvcHia38TgeVnXyCA7mRiW+MS/r69/790PzauF+37Z3e0TwOL+PGjUh9/PUfJvC1DEM BKIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=o2mz3Zi5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kx3si26532762ejc.108.2021.10.05.03.16.13; Tue, 05 Oct 2021 03:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=o2mz3Zi5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233941AbhJEKOO (ORCPT + 99 others); Tue, 5 Oct 2021 06:14:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233077AbhJEKON (ORCPT ); Tue, 5 Oct 2021 06:14:13 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD27AC061749; Tue, 5 Oct 2021 03:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UBZLxMuMMqAMN+6dt2Y8ZmEZCnKumRdcBRucu92Bimk=; b=o2mz3Zi5qgTlHUht0Zdq1S2Lt7 KEccvYnfJQi/N39tPJ4Uf2lMqVb7T3xCBSjtlPFNqWArgfzDKIcAK6CqhdYd6wUxpvQe9zGSNZI+y W1MOJoNP6JI/tdQ2Fsqrguix0qmTIBYBCgGbq+x0unlJv9QUEaHDpY8LjwibvRmbN1s6RX7BX/Gpl Q+qupSa6UAktMYJeZBrHvLWHhMg2tIuCWUkIN4SxfyVSx1FABJ+NBXqmNmYyZSihsJ//ByuQi0loa kcJtDhk2XfZliJbIMqY4SoVeErEBp3pewKb2YfVWVmLXBX+a44VNufiQb4qGT0CSGAxVWkkGeF7h6 aLu2OJbQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54952) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mXhQp-000082-SQ; Tue, 05 Oct 2021 11:12:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mXhQo-0008OH-Nz; Tue, 05 Oct 2021 11:12:18 +0100 Date: Tue, 5 Oct 2021 11:12:18 +0100 From: "Russell King (Oracle)" To: Sean Anderson , Andrew Lunn , Heiner Kallweit Cc: netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org Subject: Re: [RFC net-next PATCH 13/16] net: phy: Export get_phy_c22_id Message-ID: References: <20211004191527.1610759-1-sean.anderson@seco.com> <20211004191527.1610759-14-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004191527.1610759-14-sean.anderson@seco.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 04, 2021 at 03:15:24PM -0400, Sean Anderson wrote: > This function is useful when probing MDIO devices which present a > phy-like interface despite not using the Linux ethernet phy subsystem. Maybe we should consider moving this into mdio_device.c and renaming it if it's going to become more generic? Maybe mdio_read_c22_id()? Andrew, Heiner, any opinions? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!