Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20211004141839.49079-1-andriy.shevchenko@linux.intel.com>
 <7019ca3e-f076-e65b-f207-c23a379ade29@gmail.com>
 <20211005085100.GB17524@pengutronix.de>
User-agent: mu4e 1.6.6; emacs 27.2
From:   Felipe Balbi <balbi@kernel.org>
To:     Michael Grzeschik <mgr@pengutronix.de>
Cc:     Ferry Toth <fntoth@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to
 the right controller"
Date:   Tue, 05 Oct 2021 13:49:32 +0300
In-reply-to: <20211005085100.GB17524@pengutronix.de>
Message-ID: <87ee8zzqxr.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Michael Grzeschik <mgr@pengutronix.de> writes:

> [[PGP Signed Part:Undecided]]
> On Mon, Oct 04, 2021 at 10:35:57PM +0200, Ferry Toth wrote:
>>Hi,
>>
>>Op 04-10-2021 om 16:18 schreef Andy Shevchenko:
>>>The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right
>>>controller") changed the device for the UDC and broke the user space scripts
>>>that instantiate the USB gadget(s) via ConfigFS.
>>
>> I confirm this regression on Intel Edison since at least 5.15-rc2
>> while in 5.14.0 it was working fine.
>>
>>This patch resolves the issue as tested on 5.15-rc4.
>>
>>Tested-by: Ferry Toth<fntoth@gmail.com>
>
> NACK! Why should we resolv an issue by reverting it to solve not working
> userspace. We already have this patch as a solution for solving a deeper

heh, there is only one rule in this community: thou shalt not break
userspace :-)

-- 
balbi