Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Wong Vee Khee <vee.khee.wong@linux.intel.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Wong Vee Khee <veekhee@gmail.com>
Subject: Re: [PATCH net v4 1/1] net: pcs: xpcs: fix incorrect CL37 AN sequence
Thread-Topic: [PATCH net v4 1/1] net: pcs: xpcs: fix incorrect CL37 AN
 sequence
Thread-Index: AQHXuZqSKFnAl2vn0E2anKGAoPgHTKvET+wA
Date:   Tue, 5 Oct 2021 12:07:29 +0000
Message-ID: <20211005120728.uquop6zj2dueqbd2@skbuf>
References: <20211005034521.534125-1-vee.khee.wong@linux.intel.com>
In-Reply-To: <20211005034521.534125-1-vee.khee.wong@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fSOLP1pDbl2+VHewprFviELp0reaZji3Ki7o7SOHgu2q2bwWFsBK6v/iDgJR?=
 =?us-ascii?Q?Db0buKXvIB3hCdM0c+QuS1zEO2v55ZQLz2UHQO0Qgi09u6WDtT9SZFAY8+PE?=
 =?us-ascii?Q?yhIXGSw3l3XtwYmxCVYBAyBj6EUZ93UUIGJ34mF7FQFdZQUuMKes0oARGeSr?=
 =?us-ascii?Q?/DPXQ11+HXw8ygLExFvl1RE0kIzi/nhDigjqDKmCm5YIdIBHEUPjjPLTWO6z?=
 =?us-ascii?Q?+sTIaeNmdQGFUY+i6IHZPEZk2/UWLx0Xj/ffftO05ik8q8Tg8dqyIMxfh6Hf?=
 =?us-ascii?Q?NPnbz5dMgO1Cj4t0ez2W+Yzux9n/TR5SbdtBHTt1Rmi5gHATb4kZ2ikAtVrK?=
 =?us-ascii?Q?GLXYWdiVWpvWTrxTYwtrWmC2EB8XGt9hnv8x7X0pXQC2AQsRpRGXkyuGnt3k?=
 =?us-ascii?Q?17Z04UihpmZsjBtm/x96CMn7Q/SpTEMGhMjIVy0PnewMb/LzKWkC56fgMPeE?=
 =?us-ascii?Q?T6Ytb1qajAL3j5Cgs5ZomOBERYPlu9iA7X8PTMCX1+x3Rk+TugWdjlIzYJ+w?=
 =?us-ascii?Q?MywEap/9rVzSzAz2RU8EgBQgRs7QXL605jKLc9tjRoUV4yzWyTKokPvY8LY7?=
 =?us-ascii?Q?ZdfgztnK+zNkiv11HT4UGkYxHt0C8hk+nFYLh7UwIBjoVlXIHjM11wLCDJcZ?=
 =?us-ascii?Q?eCBIKnHx27FzWs38YvdxFBqOwkrEfc6lyj10xLqgTf4lIAOh1Ikpt/CuyNUh?=
 =?us-ascii?Q?RFHxM915CMhQaMMagAQCBDtivTxfxaZOidWxlHyI0E5CYWXuTCFqQC0KQnGa?=
 =?us-ascii?Q?rZMQsukuCpD0B79VtcnwZ3lZhg2SsoawacKF8lndKM5CrfpE2QlR/hztGj0G?=
 =?us-ascii?Q?wmjNbl/HL5w7jQc1vxR3mKorBlELKyGUGMVOyLrpBc4zjX7CkY+Hd3Oq5tDE?=
 =?us-ascii?Q?KyTMa+4JpwfY+i6ObGyQNGvqyD7+uVO3Ko3xjwdubHCoY4rtiuX2LCR7dAbs?=
 =?us-ascii?Q?/oQEUHIczmyyL41TzSn74s5ZsY1qUmbNtHRjtU7GEkAysdzwzcAKvZNBqVz2?=
 =?us-ascii?Q?MPc12djZU5gX6bxlSQ4XNKUxCaCcc8QPS9m6BtV0D2BBUe6w71JTFmTfIEph?=
 =?us-ascii?Q?4eEgNfaeLZxk2H6nMPORwtwM8ucXc/cIMQ6tidMcHU0xcOwY8xU/WLW1sbGm?=
 =?us-ascii?Q?DwLU7zhtVb4z6Stdn6j5uKylzDGEstYGfIz5mqZk5iXL+eZQSMpda4K5Kk70?=
 =?us-ascii?Q?BW5s/TSvlirL7sNKTkvUgqj2L7T38JB3GbRmg9UaHWbouUF5pX7hhuyHHp/I?=
 =?us-ascii?Q?WeYEDTvhwKYRMcl/xqK5dUe+uKp0idkMtc7TAPq0VS1M7CarHpohE784QQ6w?=
 =?us-ascii?Q?/KhBtP8mCSyFATs3HF3QhbKY?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1F4B3F99F6E97248A4E153724A891714@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1f41c3-1ea2-4750-1611-08d987f8b427
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2021 12:07:29.2176
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mtyU24J2CRaJv+Jgn9y4xsTeIhynZ+6KREyldJX+cn19CBSbxnf03W4Ik2QwZ/9tTBGzYLFQe2np1Sf4Q19dvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4814
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 05, 2021 at 11:45:21AM +0800, Wong Vee Khee wrote:
> According to Synopsys DesignWare Cores Ethernet PCS databook, it is
> required to disable Clause 37 auto-negotiation by programming bit-12
> (AN_ENABLE) to 0 if it is already enabled, before programming various
> fields of VR_MII_AN_CTRL registers.
>=20
> After all these programming are done, it is then required to enable
> Clause 37 auto-negotiation by programming bit-12 (AN_ENABLE) to 1.
>=20
> Fixes: b97b5331b8ab ("net: pcs: add C37 SGMII AN support for intel mGbE c=
ontroller")
> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> v3 -> v4:
>  - Removed redunctant 'changed' variable.

s/redunctant/redundant/

> v2 -> v3:
>  - Added error handling after xpcs_write().
>  - Added 'changed' flag.
>  - Added fixes tag.
> v1 -> v2:
>  - Removed use of xpcs_modify() helper function.
>  - Add conditional check on inband auto-negotiation.
> ---=