Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-2-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20210919093114.35987-2-krzysztof.kozlowski@canonical.com>
From:   Sam Protsenko <semen.protsenko@linaro.org>
Date:   Tue, 5 Oct 2021 15:06:55 +0300
Message-ID: <CAPLW+4mZuB426-M4_1CdiOvxBpOrHk57OeLmRY-KXs1p4QXmpQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] soc: samsung: exynos-chipid: avoid soc_device_to_device()
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Pankaj Dubey <pankaj.dubey@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> soc_device_to_device() seems to be discouraged [1] so remove it in favor
> of printing info message with platform device.  This will only change
> the prefix in theh info message from "soc soc0: " to "exynos-chipid
> 10000000.chipid:".
>
> [1] https://lore.kernel.org/lkml/20191111052741.GB3176397@kroah.com/
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  drivers/soc/samsung/exynos-chipid.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
> index 5c1d0f97f766..dcd9a08ce706 100644
> --- a/drivers/soc/samsung/exynos-chipid.c
> +++ b/drivers/soc/samsung/exynos-chipid.c
> @@ -104,8 +104,7 @@ static int exynos_chipid_probe(struct platform_device *pdev)
>
>         platform_set_drvdata(pdev, soc_dev);
>
> -       dev_info(soc_device_to_device(soc_dev),
> -                "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
> +       dev_info(&pdev->dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
>                  soc_dev_attr->soc_id, product_id, revision);
>
>         return 0;
> --
> 2.30.2
>