Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> <20210919093114.35987-4-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20210919093114.35987-4-krzysztof.kozlowski@canonical.com>
From:   Sam Protsenko <semen.protsenko@linaro.org>
Date:   Tue, 5 Oct 2021 15:10:34 +0300
Message-ID: <CAPLW+4=0K-BLGSR2O05OmRNaLuHaYandZBBUTRYm6-JnBT7QrA@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] soc: samsung: exynos-chipid: do not enforce built-in
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Pankaj Dubey <pankaj.dubey@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 19 Sept 2021 at 12:31, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> After converting the Exynos ChipID and ASV driver to a module, allow to
> actually choose it to be a module, while being a default built-in.  The
> side effect is that driver could be now entirely disabled even for
> kernel with ARCH_EXYNOS, but this is not a critical issue because driver
> is not necessary for the proper platform boot.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  arch/arm/mach-exynos/Kconfig | 1 -
>  drivers/soc/samsung/Kconfig  | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 5a48abac6af4..30f930e20599 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -13,7 +13,6 @@ menuconfig ARCH_EXYNOS
>         select ARM_GIC
>         select EXYNOS_IRQ_COMBINER
>         select COMMON_CLK_SAMSUNG
> -       select EXYNOS_CHIPID
>         select EXYNOS_THERMAL
>         select EXYNOS_PMU
>         select EXYNOS_SROM
> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
> index fe139f26d093..e2cedef1e8d1 100644
> --- a/drivers/soc/samsung/Kconfig
> +++ b/drivers/soc/samsung/Kconfig
> @@ -13,8 +13,9 @@ config EXYNOS_ASV_ARM
>         depends on EXYNOS_CHIPID
>
>  config EXYNOS_CHIPID
> -       tristate "Exynos ChipID controller and ASV driver" if COMPILE_TEST
> +       tristate "Exynos ChipID controller and ASV driver"
>         depends on ARCH_EXYNOS || COMPILE_TEST
> +       default ARCH_EXYNOS
>         select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS
>         select MFD_SYSCON
>         select SOC_BUS
> --
> 2.30.2
>