Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 5 Oct 2021 14:12:22 +0200
From:   Guido =?iso-8859-1?Q?G=FCnther?= <guido.gunther@puri.sm>
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Martin Kepplinger <martin.kepplinger@puri.sm>, robh@kernel.org,
        kernel@pengutronix.de, festevam@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
        kernel@puri.sm
Subject: Re: [PATCH v1 3/6] arm64: dts: imx8mq-librem5: wire up the wifi
 regulator
Message-ID: <YVxBJoWTDgznfsJN@qwark.sigxcpu.org>
References: <20210913135706.309685-1-martin.kepplinger@puri.sm>
 <20210913135706.309685-4-martin.kepplinger@puri.sm>
 <20211004120054.GG15650@dragon>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211004120054.GG15650@dragon>
Precedence: bulk

Hi Shawn,
On Mon, Oct 04, 2021 at 08:00:57PM +0800, Shawn Guo wrote:
> On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote:
> > From: Guido G?nther <agx@sigxcpu.org>
> > 
> > Connect the wifi power regulator to the corresponding GPIO.
> > 
> > Signed-off-by: Guido G?nther <agx@sigxcpu.org>
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> > index ba26c6ee98a0..b5562c8f9a3c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> > @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 {
> >  
> >  	reg_wifi_3v3: regulator-wifi-3v3 {
> >  		compatible = "regulator-fixed";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_wifi_pwr>;
> >  		regulator-name = "3V3_WIFI";
> >  		regulator-min-microvolt = <3300000>;
> >  		regulator-max-microvolt = <3300000>;
> > +		gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> > +		enable-active-high;
> > +		vin-supply = <&reg_vdd_3v3>;
> > +		regulator-always-on;
> 
> Any reason you need to have this always-on?

I think we can drop the `regulator-always-on` nowadays - it's wired up
correctly as `vmmc-supply` so turned on accordingly. Will drop for
the next revision.
Cheers,
 -- Guido

> 
> Shawn
> 
> >  	};
> >  
> >  	sound {
> > @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1
> >  		>;
> >  	};
> >  
> > +	pinctrl_wifi_pwr: wifipwrgrp {
> > +		fsl,pins = <
> > +			/* WIFI3V3_EN */
> > +			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10	0x83
> > +		>;
> > +	};
> > +
> >  	pinctrl_wdog: wdoggrp {
> >  		fsl,pins = <
> >  			/* nWDOG */
> > -- 
> > 2.30.2
> > 
>