Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964971AbWLTMM0 (ORCPT ); Wed, 20 Dec 2006 07:12:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754807AbWLTMMZ (ORCPT ); Wed, 20 Dec 2006 07:12:25 -0500 Received: from wx-out-0506.google.com ([66.249.82.235]:44913 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbWLTMMY (ORCPT ); Wed, 20 Dec 2006 07:12:24 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Sz1XsHA3T+L4LGC8rf6/Q+3pCnvnGNCi5lI8cZDCAaY8IGvUqhVNZw+j3nadKfhTYKa6LyGm9RUh48ZJbyMkCloY8Lk0pdaru8ZlUNPAqGw/J2vUP3OArQBjsX4qrGd/2m/+c970o+DBAvIfmM8v1BCx0Z86yKqnPzrnDiC1eck= Message-ID: <9a8748490612200412j34d90afah786bff071f34110b@mail.gmail.com> Date: Wed, 20 Dec 2006 13:12:24 +0100 From: "Jesper Juhl" To: "Peter Zijlstra" Subject: Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3) Cc: "Arjan van de Ven" , "Linus Torvalds" , "Andrei Popa" , "Andrew Morton" , "Linux Kernel Mailing List" , "Hugh Dickins" , "Florian Weimer" , "Marc Haber" , "Martin Michlmayr" , "Martin Schwidefsky" , "Heiko Carstens" , "Arnd Bergmann" In-Reply-To: <1166614939.10372.208.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1166314399.7018.6.camel@localhost> <1166471069.6940.4.camel@localhost> <1166571749.10372.178.camel@twins> <1166605296.10372.191.camel@twins> <1166607554.3365.1354.camel@laptopd505.fenrus.org> <1166614001.10372.205.camel@twins> <9a8748490612200339x4b50f0e1i3da4313bea85fbc6@mail.gmail.com> <1166614939.10372.208.camel@twins> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 22 On 20/12/06, Peter Zijlstra wrote: > On Wed, 2006-12-20 at 12:39 +0100, Jesper Juhl wrote: > > Having the assignment of "ret = 1;" inside the loop seems a little > > pointless. Perhaps gcc can optimize it, but still, that assignment > > really only needs to happen once outside the loop. > > Sure, but I was hoping gcc was smart enough. Placing it outside the loop > would require an extra if stmt. Also the chance this loop will actually > be traversed more than once is _very_ small. > allright - I just spotted it and thought I'd point it out :-) -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/