Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: schowdhu=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 05 Oct 2021 19:27:50 +0530
From:   schowdhu@codeaurora.org
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org,
        Bryan O'Donoghue <pure.logic@nexus-software.ie>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org,
        ckadabi@codeaurora.org, tsoni@codeaurora.org,
        bryanh@codeaurora.org, psodagud@codeaurora.org,
        satyap@codeaurora.org, pheragu@codeaurora.org,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Sibi Sankar <sibis@codeaurora.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH V0 4/7] usb: common: eud: Added the driver support for
 Embedded USB Debugger(EUD)
In-Reply-To: <73c1eb4f-6870-1c30-9b23-d991b8c8b35d@infradead.org>
References: <cover.1633343547.git.schowdhu@codeaurora.org>
 <e6df4a21a283e822d15dedb7ffb3ae62c241999c.1633343547.git.schowdhu@codeaurora.org>
 <73c1eb4f-6870-1c30-9b23-d991b8c8b35d@infradead.org>
Message-ID: <edb2e8a9f293bb4d55650cec983c9ced@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-10-05 01:38, Randy Dunlap wrote:
> On 10/4/21 4:16 AM, Souradeep Chowdhury wrote:
>> Add support for control peripheral of EUD (Embedded USB Debugger) to
>> listen to events such as USB attach/detach, pet EUD to indicate 
>> software
> 
>   I don't quite understand: what pets the EUD? how does it do that?

Pet EUD is an interrupt that the EUD driver receives periodically to
indicate if the software is functional. On getting the interrupt the
EUD driver first does a detach pet and then followed by the an attach
pet.

> 
>> is functional.Reusing the platform device kobj, sysfs entry 'enable' 
>> is
> 
>      functional. Reusing

Ack

> 
>> created to enable or disable EUD.
>> 
>> To enable the eud the following needs to be done
>> echo 1 >/sys/bus/platform/.../enable
>> 
>> To disable eud, following is the command
>> echo 0 >/sys/bus/platform/.../enable
>> 
>> Signed-off-by: Souradeep Chowdhury<schowdhu@codeaurora.org>
>> ---
>>   Documentation/ABI/testing/sysfs-driver-eud |   7 +
>>   drivers/usb/common/Kconfig                 |   9 +
>>   drivers/usb/common/Makefile                |   1 +
>>   drivers/usb/common/qcom_eud.c              | 256 
>> +++++++++++++++++++++++++++++
>>   4 files changed, 273 insertions(+)
>>   create mode 100644 Documentation/ABI/testing/sysfs-driver-eud
>>   create mode 100644 drivers/usb/common/qcom_eud.c
>> 
>> diff --git a/Documentation/ABI/testing/sysfs-driver-eud 
>> b/Documentation/ABI/testing/sysfs-driver-eud
>> new file mode 100644
>> index 0000000..14a02da
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-driver-eud
>> @@ -0,0 +1,7 @@
>> +What:		/sys/bus/platform/.../enable
>> +Date:           October 2021
>> +Contact:        Souradeep Chowdhury<schowdhu@codeaurora.org>
>> +Description:
>> +		The Enable/Disable sysfs interface for Embedded
>> +		USB Debugger(EUD).This enables and disables the
> 
> 		    Debugger (EUD). This enables

Ack

> 
>> +		EUD based on a 1 or a 0 value.