Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4635166pxb; Tue, 5 Oct 2021 07:16:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUosmu4VJwgD8SGjG3S/1AJ94KpwUsab4Ei/+XGVOxuWDmFLJ3LgzbCt91SucqRjCPHM1z X-Received: by 2002:a17:90a:de16:: with SMTP id m22mr4143139pjv.54.1633443392324; Tue, 05 Oct 2021 07:16:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633443392; cv=none; d=google.com; s=arc-20160816; b=FPyqKgkh7OxrSVzzendKnQWNm3b2/GkB/Pvlrx82C77fxPeAz04AsGAJuNcAAj91q1 Eq7uo4xP/kGwTRWqYUqAZzlTFLZV0/BNbj0k3Lhig1aj2+01XCSwUmQEEACZyYTV6rHM /SDMel1MuXVU8dgZpY0mnzXkmMUsg3NOZqCWJbfwiGDhwP540Xa4t8bK5iwaiYXauYGf t+l7ajnY1zVogOP01yDghkic1LwDlItfnwGV5+kH7jc/y1s9Hcu75QIYODnAx3XykrXz wM/LY3etkGBeRCQUXGdPYy+3IOrUU0EeKK5mpfhNFRJ9X8QiU3XKU8t5HVCxCn3SDgQy fx4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TZDsK7uD6ilbY716/Z/oiqMMpjwE4xNkz465mBr6hOs=; b=JQsVuckQYm67EbcUKJBSXSnAt0maCD8pwh4/3H7N6PpY8v0ISUgdZafOeoLeGLOfZq NAnSg7NV4MJyX0PFrOJC35HCaPUUMrxP73yYhTMSWhlU4K1jRurCmroyiBHOa7j4u+GT CNe6RThR8wY/Zle4JNWu+b+83H8qOiYTl/8tipKRo5i3E0aSdc+bxZnuJOPdpfTmqZgp gi9bYD+c22Te8V3+ZYiR5EIPtKIyl1Ki49fKYHiXJ3FJsQNYbjP1To2gHP2IGf1XmUfb DGK1LKslIN+bP+y6TZrxOQO+UP3uIpFWsOZ25r6A1KL1WMWBnrLn5VOUF/T+/5J8Y6/+ fUYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="mcCer/3S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y63si15720326pgd.399.2021.10.05.07.16.18; Tue, 05 Oct 2021 07:16:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="mcCer/3S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235250AbhJEOQs (ORCPT + 99 others); Tue, 5 Oct 2021 10:16:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236044AbhJEOQi (ORCPT ); Tue, 5 Oct 2021 10:16:38 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F132C0613A9 for ; Tue, 5 Oct 2021 07:13:35 -0700 (PDT) Received: from zn.tnic (p200300ec2f0d20008b62c5101b4e88fa.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:2000:8b62:c510:1b4e:88fa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 75FF41EC0489; Tue, 5 Oct 2021 16:13:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633443213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TZDsK7uD6ilbY716/Z/oiqMMpjwE4xNkz465mBr6hOs=; b=mcCer/3Sa/QYbD/Joz2lcsp/eL5jpoprpN0f7bgw54JfeL8LCWWYivKrsvIXC7dra/EnQf Ds+C4NL/k4maeuzLiu7ZSZNLt9FKL9zJ2hz3NO3/lwbkMQvqK1nJmy1lfYRT1xmdwWJdZh Xx2TiJ4HLaCT+fUpISvkdr8jRyo3HRc= Date: Tue, 5 Oct 2021 16:13:26 +0200 From: Borislav Petkov To: Sathyanarayanan Kuppuswamy Natarajan Cc: Randy Dunlap , Kuppuswamy Sathyanarayanan , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Josh Poimboeuf , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Linux Kernel Mailing List Subject: Re: [PATCH v8 02/11] x86/tdx: Introduce INTEL_TDX_GUEST config option Message-ID: References: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005025205.1784480-3-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 05, 2021 at 06:29:43AM -0700, Sathyanarayanan Kuppuswamy Natarajan wrote: > For the TDX guest, x2apic will be emulated. So it will exist in our > case. Even if x2apic or TDX guest is not supported by CPU, it will > boot just fine. Sure but why is it "select" and not "depends"? Why does X86_X2APIC need to be selected while the others are "depends"? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette