Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4639734pxb; Tue, 5 Oct 2021 07:21:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqDI6yRDy2AOI37saivApMMD8QbPdNvI3tyGC6aYVw0obrgMz4KE0Qk+AxAI9I6b58l26K X-Received: by 2002:a17:906:4c8c:: with SMTP id q12mr24958606eju.254.1633443718213; Tue, 05 Oct 2021 07:21:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633443718; cv=none; d=google.com; s=arc-20160816; b=O2bhp+sNfr+8fT8C9kjGlHR+hIEuks4uQXR/6rWmpO+42x17N7kXhs+iPuS7R3zNJ/ 3ro37wC1K/XiFYbMCOzedSTXrop35b93/m9BA1cdU1w4QzwZP02qINrQZ5iFpcsIX0eZ BMwJXT7ysljMAHGNUiVYB6c7I9qB6RYys5ANBrwB0ItMkryHvLupTxJfCookXcR7xpg6 DicOx0/rzhrtA1Kv6qD65aZHDWi9mqI2Qbw5YRmyXqf47G1fIHRNnt5xHuDWyDKgKEwi CfoLtBChCep/Cv6wIIa1Y25Y6VOCvhqLa/rjvXj/kan4nVftnFgYEebKxepW55p4bxjn N3ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Rc9cVT3WMn7G8hiCYrJp8lhJFqHxMpFnWWS+cZc07rU=; b=eAUUnXixbqdU91rjrcXU9d9zzXbClpGNkDGR+a95ZBTc17K+xW8Gd+2g53iFe4WlTH YKRC1HfSJ4cq20hWjJLUu8kavds1piXGEaLZyBWw9sXbm3lPzzEv0jnOMNb+XshPvkPc v7ZW1Zd9P9VCPrTQ8hcSLSxyIdWK+bIFOvlDvjF+NsXv71kQGPIBf10s4shAm67UTd4f Hy8+8FJ1PR9kkOzpdtlExWK4livPbRb5e0oz1NH73dfVx71uk9Y7dUjPEG0AgDDMAoxy fi9sZR/loQQ+rFHiyQPv6eDeUTUxc++SJKCbrS4VUpyHihEQE+R4rFCDieEublA71faC +Yvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs6si37342383ejc.12.2021.10.05.07.21.29; Tue, 05 Oct 2021 07:21:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235449AbhJEOVu (ORCPT + 99 others); Tue, 5 Oct 2021 10:21:50 -0400 Received: from netrider.rowland.org ([192.131.102.5]:47787 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S234899AbhJEOVu (ORCPT ); Tue, 5 Oct 2021 10:21:50 -0400 Received: (qmail 622086 invoked by uid 1000); 5 Oct 2021 10:19:58 -0400 Date: Tue, 5 Oct 2021 10:19:58 -0400 From: Alan Stern To: Greg Kroah-Hartman Cc: Nikita Yushchenko , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Nechaev Subject: Re: [PATCH v3] usb: gadget: storage: add support for media larger than 2T Message-ID: <20211005141958.GA621017@rowland.harvard.edu> References: <20210921145901.11952-1-nikita.yoush@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 05, 2021 at 01:07:58PM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 21, 2021 at 05:59:02PM +0300, Nikita Yushchenko wrote: > > This adds support for READ_CAPACITY(16), READ(16) and WRITE(16) > > commands, and fixes READ_CAPACITY command to return 0xffffffff if > > media size does not fit in 32 bits. > > > > This makes f_mass_storage to export a 16T disk array correctly. > > > > Signed-off-by: Nikita Yushchenko > > --- > > v3: > > - added this changelog > > > > v2: > > - fixed call to check_command() for READ_CAPACITY(16) > > - fixed alphabetical order of commands in switch statement > > - renamed variable, added comments, and fixed formatting, per advices by > > Alan Stern > > Felipe and Alan, any objections to this change? No objections. In fact, I already sent my Acked-by for v2 of the patch (which is the same as v3): https://marc.info/?l=linux-usb&m=163165151506682&w=2 Alan Stern