Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A00F6C4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath11k: Remove unused variable in
 ath11k_dp_rx_mon_merg_msdus()
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210927150743.19816-1-tim.gardner@canonical.com>
References: <20210927150743.19816-1-tim.gardner@canonical.com>
To:     Tim Gardner <tim.gardner@canonical.com>
Cc:     ath11k@lists.infradead.org, tim.gardner@canonical.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-Id: <20211005142930.6413FC43617@smtp.codeaurora.org>
Date:   Tue,  5 Oct 2021 14:29:30 +0000 (UTC)
Precedence: bulk

Tim Gardner <tim.gardner@canonical.com> wrote:

> Coverity complains that a constant variable guards dead code. In fact,
> mpdu_buf is set NULL and never updated.
> 
> 4834err_merge_fail:
>         null: At condition mpdu_buf, the value of mpdu_buf must be NULL.
>         dead_error_condition: The condition mpdu_buf cannot be true.
> CID 92162 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
> dead_error_line: Execution cannot reach the expression decap_format !=
>   DP_RX_DECAP_TYPE_RAW inside this statement: if (mpdu_buf && decap_forma....
> Local variable mpdu_buf is assigned only once, to a constant value, making it
>   effectively constant throughout its scope. If this is not the intent, examine
>   the logic to see if there is a missing assignment that would make mpdu_buf not
>   remain constant.
> 4835        if (mpdu_buf && decap_format != DP_RX_DECAP_TYPE_RAW) {
> 
> Fix this by removing mpdu_buf and unreachable code.
> 
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: ath11k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

7210b4b77fe4 ath11k: Remove unused variable in ath11k_dp_rx_mon_merg_msdus()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210927150743.19816-1-tim.gardner@canonical.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches