Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4653898pxb; Tue, 5 Oct 2021 07:39:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZYe+ut8ER5kosDR+bQTHM12Hdi8ZigkV9a6SOIzYmjlkOyrYyX2oN71vNdG/Ln2k8b0mj X-Received: by 2002:a05:6a00:216f:b0:44b:6212:4967 with SMTP id r15-20020a056a00216f00b0044b62124967mr31877747pff.23.1633444742612; Tue, 05 Oct 2021 07:39:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633444742; cv=none; d=google.com; s=arc-20160816; b=HVBn0u1kAYfFJOP1TqP60sd/es3SQOGbgypsOAoaiFxB3QtnqC7rF+bN9EoaCPdnOA ApL/tDc1B/PB4Aj1/xo8ufLPkXs+xnnFdK+/RHbEnrzWOq9+7trUGh2BRd2QHzzDHvlD 8bH6UYAOLqtNcWDzSorrEvupYiTxc24uskrapmdevRFl/B8bGTXSZCxxkQezqbxtjbd5 pm1EteIxs5DUhqyrSfjKEBH0/CslgLsyWJbLAJLLgZowE9x0N4K15z3GbcJLcqR+6kKc CT0r5IBWjH88YJi9rhqwqaaLDOalxhQzaZK8wkZ8Zxth3KsFiqH8KlywAKXOsvEMa6Ri Y7dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NXVT547q11vxBmN0JnCHuyJ+/+kUBjr0nC1nL/Y5gs8=; b=WlNMucEsWSqnqE2/+DpX3NCKHBViTPAzPmhM8G3ajPp6+3Z/eK9JLd0qh7Oo1tU7bp d+Fwilh42NwzMlYM7iwpNd6KB8wak965EpR837C01iQ8FiTYEq+O92LnX8kmYslI4kST U14stw6jESdBLlrSmZbb5Suf3Zey/pAYSKZ+GyxnrIXI1EXOEUWJorfAB9bNmuyJwBr2 q3dscSBbelJBv9toZxCyGpVa4V52iBjeEsUgMJ6O333J5rdFTZ+pPVtOK8levPXudzI9 geN0VXn7sqX8MoonOjm64sApyQL5sFSSAujzITFKI/XTRRoyPWNJWF5tBxNEqevVkiqc lcVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=mP1JnpeU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lb14si2892807pjb.108.2021.10.05.07.38.48; Tue, 05 Oct 2021 07:39:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=mP1JnpeU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235335AbhJEOj0 (ORCPT + 99 others); Tue, 5 Oct 2021 10:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234084AbhJEOjZ (ORCPT ); Tue, 5 Oct 2021 10:39:25 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCDCC061749; Tue, 5 Oct 2021 07:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NXVT547q11vxBmN0JnCHuyJ+/+kUBjr0nC1nL/Y5gs8=; b=mP1JnpeUdMoGUG0of2rU8oOvaR n7csvi9rY8/SEFwTuD6fzd+RSWW8AjhudXBQEJl2V5sOSMGFsjQbWG/AH5UhHDHKEuXfglXOGm25M JgVLJRTXxeg/i3Gq7waOsj2cBgOS3kPVMTolADirJaGu8H0NCsnkgZtZ7+Mf5WKWa/8kRTyIUFUBI q8PL3uMiyVJJmGBXP7KUAhgouW2MeZzn4zZny0oK8FZ18stFi47qmgU3NROIBuavFPsqzM/F+bNuZ xmAPZ5YvZqGVFtxTLfqX9PFJdQW9XVgPe1GCuqvR59RoAecUagUq6sUF1/NG3yy8HzY6st8oSDua+ Njbx8NBw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXlZI-00846d-FS; Tue, 05 Oct 2021 14:37:20 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9DD7930019C; Tue, 5 Oct 2021 16:37:19 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7D60D2038E211; Tue, 5 Oct 2021 16:37:19 +0200 (CEST) Date: Tue, 5 Oct 2021 16:37:19 +0200 From: Peter Zijlstra To: Marco Elver Cc: "Paul E . McKenney" , Alexander Potapenko , Boqun Feng , Borislav Petkov , Dmitry Vyukov , Ingo Molnar , Josh Poimboeuf , Mark Rutland , Thomas Gleixner , Waiman Long , Will Deacon , kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH -rcu/kcsan 23/23] objtool, kcsan: Remove memory barrier instrumentation from noinstr Message-ID: References: <20211005105905.1994700-1-elver@google.com> <20211005105905.1994700-24-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211005105905.1994700-24-elver@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 05, 2021 at 12:59:05PM +0200, Marco Elver wrote: > Teach objtool to turn instrumentation required for memory barrier > modeling into nops in noinstr text. > > The __tsan_func_entry/exit calls are still emitted by compilers even > with the __no_sanitize_thread attribute. The memory barrier > instrumentation will be inserted explicitly (without compiler help), and > thus needs to also explicitly be removed. How is arm64 and others using kernel/entry + noinstr going to fix this? ISTR they fully rely on the compilers not emitting instrumentation, since they don't have objtool to fix up stray issues like this.